feat: Migrate vote tab to wagmi #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Majorfi
requested changes
Jun 26, 2023
Comment on lines
84
to
87
| type TDelegateVote = TWriteTransaction & {delegateAddress: TAddress}; | ||
| export async function delegateVote(props: TDelegateVote): Promise<TTxResponse> { | ||
| assertAddress(props.contractAddress); | ||
|
|
There was a problem hiding this comment.
Suggested change
| type TDelegateVote = TWriteTransaction & {delegateAddress: TAddress}; | |
| export async function delegateVote(props: TDelegateVote): Promise<TTxResponse> { | |
| assertAddress(props.contractAddress); | |
| type TDelegateVote = TWriteTransaction & {delegateAddress: TAddress}; | |
| export async function delegateVote(props: TDelegateVote): Promise<TTxResponse> { | |
| assertAddress(props.contractAddress); | |
| assertAddress(props.delegateAddress); | |
There was a problem hiding this comment.
For these cases, should we use the new util from #253 (comment)?
There was a problem hiding this comment.
Like this d8dbcdb
Had to refactor the util function to handle the cases a bit better
karelianpie
force-pushed
the
feat/veyfi-gauges-merged-vote-tab
branch
from
e548e58
to
a248253
Compare
karelianpie
force-pushed
the
feat/veyfi-gauges-merged-vote-tab
branch
from
d8dbcdb
to
d75c43c
Compare
xgambitox
approved these changes
Jun 26, 2023
karelianpie
force-pushed
the
feat/veyfi-gauges-merged-vote-tab
branch
from
d75c43c
to
bc1da6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
VoteTabto wagmi, feature branch of #248