Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: veYFI gauge #248

Merged
merged 154 commits into from
Aug 28, 2023
Merged

feat: veYFI gauge #248

merged 154 commits into from
Aug 28, 2023

Conversation

karelianpie
Copy link
Member

@karelianpie karelianpie commented Jun 21, 2023 •
edited
Loading

Gauge voting for veYFI

Continuation of #56

Under the gauge-voting feature flag

http://localhost:3000/veyfi?features=gauge-voting

@xgambitox
feat: add delegate vote action
32de2e3
@xgambitox
feat: add address validation
c229909
@xgambitox
feat: add input common component
02d7787
@xgambitox
feat: add gauge vote tab
8cd51b9
@xgambitox
feat: add base gauge context
4bae35f
@xgambitox
feat: add gauge actions
812d64c
@xgambitox
feat: add table common component
71e3286
@xgambitox
feat: add gauge tab with mock data
2d0317d
@xgambitox
Merge branch 'main' into feat/veyfi-gauges
3d19e2a
@xgambitox
refactor: sort order states
b47247a
@xgambitox
fix: table sizing
b6b2f71
@xgambitox
fix: table header font size
fc0ba64
@xgambitox
refactor: isNumber cast
b659c8f
@xgambitox
style: readability improvements
cb5fc76
@xgambitox
refactor: input placeholder
718754a
@xgambitox
refactor: nullish coalescing
bdfd9cd
@xgambitox
refactor: sort numbers
155ff23
@xgambitox
refactor: keyBy typing
4393a09
@xgambitox
refactor: isString util
7464430
@xgambitox
style: remove unnecessary unknowns
f5bb55b
@xgambitox
style: remove unnesessary cast
97e76ff
@xgambitox
refactor: replace mt for gap
d1ec775
@xgambitox
style: isNumberable better naming
5168a9f
@xgambitox
fix: gauge tab table span
56bf773
@xgambitox
fix: update unstake interface changes
5a2a31e
@xgambitox
feat: add gauge reward position
fb64f0e
@xgambitox
feat: add gauge boost
73f55a1
@xgambitox
refactor: user positions not optional
5253c87
@xgambitox
feat: add base generic dropdown component
ebeb370
@xgambitox
feat: add dropdown improvements
c03ef79
@0xBasically 0xBasically added the enhancement New feature or request label Aug 11, 2023
@0xBasically
Copy link
Contributor

@karelianpie this is waiting for the contracts to be live to be merged or?

@0xBasically 0xBasically added Ready hold Waiting for something labels Aug 17, 2023
@karelianpie
Copy link
Member Author

@karelianpie this is waiting for the contracts to be live to be merged or?

First is waiting for reviews

@karelianpie karelianpie removed the Ready label Aug 18, 2023
@karelianpie karelianpie changed the title feat: veYFI gauges merged feat: veYFI gauge Aug 24, 2023
@karelianpie karelianpie mentioned this pull request Aug 24, 2023
Merged
@karelianpie
Copy link
Member Author

@Majorfi added the gauge-voting feature flag with 063c3a0

Would you mind having another look so that we can merge this?

@karelianpie karelianpie removed the hold Waiting for something label Aug 24, 2023
Majorfi
Majorfi previously approved these changes Aug 28, 2023
View reviewed changes
@Majorfi
Copy link
Collaborator

Majorfi commented Aug 28, 2023

@karelianpie Looks good to me!
Could you add a changelog entry ? 🔥

@karelianpie
Copy link
Member Author

@karelianpie Looks good to me! Could you add a changelog entry ? 🔥

Added with 9309920

@Majorfi Majorfi merged commit abaf3a7 into main Aug 28, 2023
10 checks passed
@Majorfi Majorfi deleted the feat/veyfi-gauges-merged branch August 28, 2023 12:39
@karelianpie karelianpie mentioned this pull request Sep 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Majorfi Majorfi Majorfi approved these changes

@xgambitox xgambitox Awaiting requested review from xgambitox

Assignees

@karelianpie karelianpie

Labels
enhancement New feature or request
Projects
Yearn - Xopowo
Status: 🟢 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karelianpie @0xBasically @Majorfi @xgambitox @murderteeth