Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Check that error is an instance of BaseError #226

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

karelianpie
Copy link
Member

@karelianpie karelianpie commented Jun 6, 2023

⚠️ Depends on yearn/web-lib#259

Instead of casting, let's check that error is an instance of BaseError.

This way we are certain that it has the props we need

@karelianpie karelianpie requested a review from Majorfi June 6, 2023 09:57
@karelianpie karelianpie self-assigned this Jun 6, 2023
@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yearnfi ❌ Failed (Inspect) Jun 6, 2023 1:29pm

@Majorfi Majorfi merged commit 1268de2 into main Jun 6, 2023
@Majorfi Majorfi deleted the refactor/check-instance-baseerror branch June 6, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🟢 Done
Development

Successfully merging this pull request may close these issues.

2 participants