Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: APY #290

Closed
karelianpie opened this issue Jul 20, 2023 · 0 comments · Fixed by #292
Closed

Bug: APY #290

karelianpie opened this issue Jul 20, 2023 · 0 comments · Fixed by #292
Assignees
@karelianpie
Labels
bug Something isn't working

Comments

@karelianpie
Copy link
Member

What happened 🆘

(maybe merge conflict)

reward is showing up for all of the vaults now, but it's all of a sudden not factored into the main displayed APY anymore weirdly...also some of those logos still missing

apy is not being displayed as it used to, as the reward apy used to be added to the main apy number, such that the main apy should always be bigger than reward apy.

I think we should do gross + stacking in fe

To Reproduce 🔂

Steps to reproduce the behavior:

More 🔎

  • Browser :
@karelianpie karelianpie added the bug Something isn't working label Jul 20, 2023
@karelianpie karelianpie self-assigned this Jul 20, 2023
@karelianpie karelianpie mentioned this issue Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karelianpie karelianpie

Labels
bug Something isn't working
Projects
Yearn - Xopowo
Status: 🟢 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Rewards APY (gross + stacking) yearn/yearn.fi
1 participant
@karelianpie