Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Events in HealthCheck #503

Closed
rareweasel opened this issue Dec 17, 2021 · 3 comments
Closed

Add Events in HealthCheck #503

rareweasel opened this issue Dec 17, 2021 · 3 comments

Comments

@rareweasel
Copy link

Add the corresponding events in the following functions:

  • BaseStrategy.setHealthCheck.
  • BaseStrategy.setDoHealthCheck.

Also, the harvest() function modifies the doHealthCheck here without emitting an event.

Output

Emit events in both functions and in the harvest function where the doHealthCheck variables is modified.

Target Tag/Branch

Since the health check is not present in the main branch, the target is v0.4.3

https://github.com/yearn/yearn-vaults/tree/v0.4.3

@rareweasel rareweasel changed the title Add Events in HealthCheck Changes Add Events in HealthCheck Dec 17, 2021
@rareweasel
Copy link
Author

Hi @pandadefi are you planning to impl this? any ETA?

I saw there is a merged pr but it looks like it is not what we needed for this issue.

@pandadefi
Copy link
Contributor

pandadefi commented Jan 6, 2022

After 0.4.3 the heath check isn't on Base strategy but on vault to reduce Base strategy size.

@pandadefi
Copy link
Contributor

efb47d8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants