Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a "Select all" for the filters #113

Merged
merged 3 commits into from
Aug 10, 2023
Merged

feat: Add a "Select all" for the filters #113

merged 3 commits into from
Aug 10, 2023

Conversation

karelianpie
Copy link
Member

Description

Add a new checkbox to (de)select all filters

Related Issue

Closes #110

Motivation and Context

Allow users to quickly select filters. Best use case is when a user wants just one filter, they can click on "Select all", then again and it will deselect all, then they can just select the one they are interested in.

How Has This Been Tested?

Locally, checking/unchecking the chexkbox

Screenshots (if appropriate):

Screenshot 2023-08-07 at 13 55 27 Screenshot 2023-08-07 at 13 55 31

@karelianpie karelianpie self-assigned this Aug 7, 2023
@vercel
Copy link

vercel bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ysync ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 10:23am

Copy link
Collaborator

@Majorfi Majorfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a effect to catch when they are all selected manually 🙏

@karelianpie
Copy link
Member Author

I would add a effect to catch when they are all selected manually 🙏

What's the expected behaviour?

  • All filters checked => Select All checked
  • No filters checked => Select All unchecked
  • Partially filters checked => Select All unchecked

So "Select All" is only checked when all filters are checked, as soon as 1 becomes unchecked then the Select All becomes unchecked as well?

@karelianpie
Copy link
Member Author

I would add a effect to catch when they are all selected manually 🙏

Done #113 (comment) with 10cfacf

0xBasically
0xBasically previously approved these changes Aug 7, 2023
Copy link
Contributor

@0xBasically 0xBasically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@0xBasically 0xBasically added the enhancement New feature or request label Aug 7, 2023
pages/index.tsx Outdated Show resolved Hide resolved
@Majorfi Majorfi merged commit 5727974 into next Aug 10, 2023
4 checks passed
@Majorfi Majorfi deleted the issues/110 branch August 10, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🟢 Done
Development

Successfully merging this pull request may close these issues.

FRP: Add a "Select all" for the filters
3 participants