-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a "Select all" for the filters #113
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a effect to catch when they are all selected manually 🙏
What's the expected behaviour?
So "Select All" is only checked when all filters are checked, as soon as 1 becomes unchecked then the Select All becomes unchecked as well? |
Done #113 (comment) with 10cfacf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Add a new checkbox to (de)select all filters
Related Issue
Closes #110
Motivation and Context
Allow users to quickly select filters. Best use case is when a user wants just one filter, they can click on "Select all", then again and it will deselect all, then they can just select the one they are interested in.
How Has This Been Tested?
Locally, checking/unchecking the chexkbox
Screenshots (if appropriate):