feat: Add isZero helper
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majorfi
reviewed
Jun 6, 2023
| test.each([ | ||
| [0, true], | ||
| ['0', true], | ||
| ['0.0', true], |
There was a problem hiding this comment.
Should we also accept 0,0?
Looks a bit overkill tbh but if we compare locale we could hit that
There was a problem hiding this comment.
I don't think it's an overkill, it's a great one! The idea here is that this is the helper function that you can give anything and it will let you know if it's zero :)
Added support for 0,0 with 4969719
Majorfi
requested changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
isZerohelper, should take almost anything and check if it's zeroRelated Issue
Closes #255
Motivation and Context
We don't want to constantly be comparing stuff to
0nor0, it's error prone and might not handle all cases. Therefore, we want a single function that can take almost anything and will check if it's zero.How Has This Been Tested?
utils/isZero.test.ts