Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use web-lib version of useWindowInFocus hook #218

Closed
0xMirim opened this issue Jul 11, 2023 · 1 comment
Closed

Use web-lib version of useWindowInFocus hook #218

0xMirim opened this issue Jul 11, 2023 · 1 comment
Assignees

Comments

@0xMirim
Copy link
Contributor

0xMirim commented Jul 11, 2023

What is your proposal 🚀

We have a local versions of useWindowInFocus hook but there is also an equivalent hook in web-lib.

ours: https://github.com/saltyfacu/ape-tax/blob/master/hook/useWindowInFocus.tsx
web-lib's: https://github.com/yearn/web-lib/blob/main/packages/web-lib/hooks/useWindowInFocus.tsx

Seems like we can update local imports to use web-lib instead, then remove the local hook from the repo

What does this solve ? 🛠

Trade off of reducing local code, but increasing dependence on web-lib. Should be fine to do this.

@0xMirim
Copy link
Contributor Author

0xMirim commented Jul 12, 2023

Completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants