We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useWindowInFocus
We have a local versions of useWindowInFocus hook but there is also an equivalent hook in web-lib.
ours: https://github.com/saltyfacu/ape-tax/blob/master/hook/useWindowInFocus.tsx web-lib's: https://github.com/yearn/web-lib/blob/main/packages/web-lib/hooks/useWindowInFocus.tsx
Seems like we can update local imports to use web-lib instead, then remove the local hook from the repo
Trade off of reducing local code, but increasing dependence on web-lib. Should be fine to do this.
The text was updated successfully, but these errors were encountered:
Completed
Sorry, something went wrong.
Itzabelli
No branches or pull requests
What is your proposal 🚀
We have a local versions of
useWindowInFocus
hook but there is also an equivalent hook in web-lib.ours: https://github.com/saltyfacu/ape-tax/blob/master/hook/useWindowInFocus.tsx
web-lib's: https://github.com/yearn/web-lib/blob/main/packages/web-lib/hooks/useWindowInFocus.tsx
Seems like we can update local imports to use web-lib instead, then remove the local hook from the repo
What does this solve ? 🛠
Trade off of reducing local code, but increasing dependence on web-lib. Should be fine to do this.
The text was updated successfully, but these errors were encountered: