diff --git a/ydb/core/tx/columnshard/blobs_action/transaction/tx_blobs_written.h b/ydb/core/tx/columnshard/blobs_action/transaction/tx_blobs_written.h index d758031bd763..9284b3aa1bd0 100644 --- a/ydb/core/tx/columnshard/blobs_action/transaction/tx_blobs_written.h +++ b/ydb/core/tx/columnshard/blobs_action/transaction/tx_blobs_written.h @@ -1,7 +1,7 @@ #pragma once #include #include -#include +#include #include #include #include @@ -12,9 +12,9 @@ namespace NKikimr::NColumnShard { class TColumnShard; -class TTxBlobsWritingFinished: public NOlap::NDataSharing::TExtendedTransactionBase { +class TTxBlobsWritingFinished: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; std::vector Packs; const std::shared_ptr WritingActions; std::optional CommitSnapshot; @@ -51,9 +51,9 @@ class TTxBlobsWritingFinished: public NOlap::NDataSharing::TExtendedTransactionB } }; -class TTxBlobsWritingFailed: public NOlap::NDataSharing::TExtendedTransactionBase { +class TTxBlobsWritingFailed: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const NKikimrProto::EReplyStatus PutBlobResult; std::vector Packs; diff --git a/ydb/core/tx/columnshard/blobs_action/transaction/tx_write.h b/ydb/core/tx/columnshard/blobs_action/transaction/tx_write.h index aa626c9ea8ed..c93b26c0d3de 100644 --- a/ydb/core/tx/columnshard/blobs_action/transaction/tx_write.h +++ b/ydb/core/tx/columnshard/blobs_action/transaction/tx_write.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NColumnShard { -class TTxWrite: public NOlap::NDataSharing::TExtendedTransactionBase { +class TTxWrite: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; public: TTxWrite(TColumnShard* self, const TEvPrivate::TEvWriteBlobsResult::TPtr& putBlobResult) diff --git a/ydb/core/tx/columnshard/columnshard_impl.h b/ydb/core/tx/columnshard/columnshard_impl.h index 89c34e6cebbe..f0a630945dc5 100644 --- a/ydb/core/tx/columnshard/columnshard_impl.h +++ b/ydb/core/tx/columnshard/columnshard_impl.h @@ -11,7 +11,7 @@ #include "blobs_action/events/delete_blobs.h" #include "counters/columnshard.h" #include "counters/counters_manager.h" -#include "data_sharing/common/transactions/tx_extension.h" +#include "tablet/ext_tx_base.h" #include "data_sharing/destination/events/control.h" #include "data_sharing/destination/events/transfer.h" #include "data_sharing/manager/sessions.h" diff --git a/ydb/core/tx/columnshard/data_sharing/common/transactions/ya.make b/ydb/core/tx/columnshard/data_sharing/common/transactions/ya.make deleted file mode 100644 index 30aa6d488922..000000000000 --- a/ydb/core/tx/columnshard/data_sharing/common/transactions/ya.make +++ /dev/null @@ -1,17 +0,0 @@ -LIBRARY() - -SRCS( - tx_extension.cpp -) - -PEERDIR( - ydb/core/tablet_flat - ydb/core/tx/tiering - ydb/services/metadata/abstract - ydb/core/tx/columnshard/data_sharing/protos - ydb/core/tx/columnshard/blobs_action/protos - ydb/core/base - ydb/core/tx/tiering -) - -END() diff --git a/ydb/core/tx/columnshard/data_sharing/common/ya.make b/ydb/core/tx/columnshard/data_sharing/common/ya.make index 1d1caafc12c6..172bcd1b86f0 100644 --- a/ydb/core/tx/columnshard/data_sharing/common/ya.make +++ b/ydb/core/tx/columnshard/data_sharing/common/ya.make @@ -2,7 +2,6 @@ LIBRARY() PEERDIR( ydb/core/tx/columnshard/data_sharing/common/session - ydb/core/tx/columnshard/data_sharing/common/transactions ydb/core/tx/columnshard/data_sharing/common/context ) diff --git a/ydb/core/tx/columnshard/data_sharing/destination/session/ya.make b/ydb/core/tx/columnshard/data_sharing/destination/session/ya.make index 92588efad0f8..8e936403fd41 100644 --- a/ydb/core/tx/columnshard/data_sharing/destination/session/ya.make +++ b/ydb/core/tx/columnshard/data_sharing/destination/session/ya.make @@ -7,7 +7,7 @@ SRCS( PEERDIR( ydb/core/tx/columnshard/data_sharing/initiator/controller ydb/core/tx/columnshard/data_sharing/common/session - ydb/core/tx/columnshard/data_sharing/common/transactions + ydb/core/tx/columnshard/tablet ydb/core/tx/columnshard/data_sharing/destination/transactions ) diff --git a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_data_from_source.h b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_data_from_source.h index 91d48eb76346..6bc90df7f5dd 100644 --- a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_data_from_source.h +++ b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_data_from_source.h @@ -1,7 +1,7 @@ #pragma once #include #include -#include +#include #include #include #include @@ -9,9 +9,9 @@ namespace NKikimr::NOlap::NDataSharing { -class TTxDataFromSource: public TExtendedTransactionBase { +class TTxDataFromSource: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; THashMap PortionsByPathId; THashMap> SharedBlobIds; diff --git a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_ack_from_initiator.h b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_ack_from_initiator.h index 0d61359a1e8f..84a833e5afc8 100644 --- a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_ack_from_initiator.h +++ b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_ack_from_initiator.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NOlap::NDataSharing { -class TTxFinishAckFromInitiator: public TExtendedTransactionBase { +class TTxFinishAckFromInitiator: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; protected: virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const TActorContext& ctx) override; diff --git a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_from_source.h b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_from_source.h index 982029b2c928..3f4ef3894ff5 100644 --- a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_from_source.h +++ b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_finish_from_source.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NOlap::NDataSharing { -class TTxFinishFromSource: public TExtendedTransactionBase { +class TTxFinishFromSource: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; const TTabletId SourceTabletId; bool Finished = false; diff --git a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_start_from_initiator.h b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_start_from_initiator.h index e90a2af29935..ed6d7cda3e68 100644 --- a/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_start_from_initiator.h +++ b/ydb/core/tx/columnshard/data_sharing/destination/transactions/tx_start_from_initiator.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NOlap::NDataSharing { -class TTxProposeFromInitiator: public TExtendedTransactionBase { +class TTxProposeFromInitiator: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; THashMap>* Sessions; protected: @@ -23,9 +23,9 @@ class TTxProposeFromInitiator: public TExtendedTransactionBase { +class TTxConfirmFromInitiator: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; protected: virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const TActorContext& ctx) override; diff --git a/ydb/core/tx/columnshard/data_sharing/destination/transactions/ya.make b/ydb/core/tx/columnshard/data_sharing/destination/transactions/ya.make index db1eca3269fa..d3a315dcb592 100644 --- a/ydb/core/tx/columnshard/data_sharing/destination/transactions/ya.make +++ b/ydb/core/tx/columnshard/data_sharing/destination/transactions/ya.make @@ -10,7 +10,7 @@ SRCS( PEERDIR( ydb/core/tx/tiering ydb/core/tx/columnshard/data_sharing/protos - ydb/core/tx/columnshard/data_sharing/common/transactions + ydb/core/tx/columnshard/tablet ) END() diff --git a/ydb/core/tx/columnshard/data_sharing/modification/tasks/ya.make b/ydb/core/tx/columnshard/data_sharing/modification/tasks/ya.make index f42b0f0c234e..075efbb95513 100644 --- a/ydb/core/tx/columnshard/data_sharing/modification/tasks/ya.make +++ b/ydb/core/tx/columnshard/data_sharing/modification/tasks/ya.make @@ -7,7 +7,7 @@ SRCS( PEERDIR( ydb/core/tx/columnshard/data_sharing/initiator/controller ydb/core/tx/columnshard/data_sharing/common/session - ydb/core/tx/columnshard/data_sharing/common/transactions + ydb/core/tx/columnshard/tablet ydb/core/tx/columnshard/data_sharing/destination/transactions ) diff --git a/ydb/core/tx/columnshard/data_sharing/modification/transactions/tx_change_blobs_owning.h b/ydb/core/tx/columnshard/data_sharing/modification/transactions/tx_change_blobs_owning.h index d32ae4504563..77cd10ec35a7 100644 --- a/ydb/core/tx/columnshard/data_sharing/modification/transactions/tx_change_blobs_owning.h +++ b/ydb/core/tx/columnshard/data_sharing/modification/transactions/tx_change_blobs_owning.h @@ -1,15 +1,15 @@ #pragma once #include #include -#include +#include namespace NKikimr::NOlap::NDataSharing { class TTaskForTablet; -class TTxApplyLinksModification: public TExtendedTransactionBase { +class TTxApplyLinksModification: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Task; const TTabletId InitiatorTabletId; const TString SessionId; diff --git a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_data_ack_to_source.h b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_data_ack_to_source.h index a8a4756a94f8..0c5a99bbcbce 100644 --- a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_data_ack_to_source.h +++ b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_data_ack_to_source.h @@ -1,14 +1,14 @@ #pragma once #include -#include +#include #include #include namespace NKikimr::NOlap::NDataSharing { -class TTxDataAckToSource: public TExtendedTransactionBase { +class TTxDataAckToSource: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; THashMap SharedBlobIds; protected: diff --git a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_finish_ack_to_source.h b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_finish_ack_to_source.h index 3c03f5f7e9c7..d63e5ef0abad 100644 --- a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_finish_ack_to_source.h +++ b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_finish_ack_to_source.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NOlap::NDataSharing { -class TTxFinishAckToSource: public TExtendedTransactionBase { +class TTxFinishAckToSource: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; protected: virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const TActorContext& ctx) override; diff --git a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_source_cursor.h b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_source_cursor.h index b558ab4eabd4..d75cd64d3fc8 100644 --- a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_source_cursor.h +++ b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_source_cursor.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NOlap::NDataSharing { -class TTxStartSourceCursor: public TExtendedTransactionBase { +class TTxStartSourceCursor: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; TSourceSession* Session; THashMap> Portions; diff --git a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_to_source.h b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_to_source.h index 6506f269a75c..ed4cf37b3676 100644 --- a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_to_source.h +++ b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_start_to_source.h @@ -1,13 +1,13 @@ #pragma once #include -#include +#include #include namespace NKikimr::NOlap::NDataSharing { -class TTxStartToSource: public TExtendedTransactionBase { +class TTxStartToSource: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; THashMap>* Sessions; protected: diff --git a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_write_source_cursor.h b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_write_source_cursor.h index 315e6038ed41..1bc6a50b2c1c 100644 --- a/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_write_source_cursor.h +++ b/ydb/core/tx/columnshard/data_sharing/source/transactions/tx_write_source_cursor.h @@ -1,14 +1,14 @@ #pragma once #include -#include +#include #include #include namespace NKikimr::NOlap::NDataSharing { -class TTxWriteSourceCursor: public TExtendedTransactionBase { +class TTxWriteSourceCursor: public NColumnShard::TExtendedTransactionBase { private: - using TBase = TExtendedTransactionBase; + using TBase = NColumnShard::TExtendedTransactionBase; std::shared_ptr Session; protected: virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const TActorContext& ctx) override; diff --git a/ydb/core/tx/columnshard/data_sharing/source/transactions/ya.make b/ydb/core/tx/columnshard/data_sharing/source/transactions/ya.make index 824427fed1a8..b8a9f2016432 100644 --- a/ydb/core/tx/columnshard/data_sharing/source/transactions/ya.make +++ b/ydb/core/tx/columnshard/data_sharing/source/transactions/ya.make @@ -9,7 +9,7 @@ SRCS( ) PEERDIR( - ydb/core/tx/columnshard/data_sharing/common/transactions + ydb/core/tx/columnshard/tablet ) END() diff --git a/ydb/core/tx/columnshard/inflight_request_tracker.cpp b/ydb/core/tx/columnshard/inflight_request_tracker.cpp index da287c2f6b99..524317c061a8 100644 --- a/ydb/core/tx/columnshard/inflight_request_tracker.cpp +++ b/ydb/core/tx/columnshard/inflight_request_tracker.cpp @@ -1,8 +1,7 @@ #include "columnshard_impl.h" #include "columnshard_schema.h" #include "inflight_request_tracker.h" - -#include "data_sharing/common/transactions/tx_extension.h" +#include "tablet/ext_tx_base.h" #include "engines/column_engine.h" #include "engines/reader/plain_reader/constructor/read_metadata.h" #include "hooks/abstract/abstract.h" @@ -60,9 +59,9 @@ void TInFlightReadsTracker::AddToInFlightRequest( } namespace { -class TTransactionSavePersistentSnapshots: public NOlap::NDataSharing::TExtendedTransactionBase { +class TTransactionSavePersistentSnapshots: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const std::set SaveSnapshots; const std::set RemoveSnapshots; virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const TActorContext& /*ctx*/) override { diff --git a/ydb/core/tx/columnshard/data_sharing/common/transactions/tx_extension.cpp b/ydb/core/tx/columnshard/tablet/ext_tx_base.cpp similarity index 100% rename from ydb/core/tx/columnshard/data_sharing/common/transactions/tx_extension.cpp rename to ydb/core/tx/columnshard/tablet/ext_tx_base.cpp diff --git a/ydb/core/tx/columnshard/data_sharing/common/transactions/tx_extension.h b/ydb/core/tx/columnshard/tablet/ext_tx_base.h similarity index 91% rename from ydb/core/tx/columnshard/data_sharing/common/transactions/tx_extension.h rename to ydb/core/tx/columnshard/tablet/ext_tx_base.h index ea9c99c7fd9d..0ce09cd536d0 100644 --- a/ydb/core/tx/columnshard/data_sharing/common/transactions/tx_extension.h +++ b/ydb/core/tx/columnshard/tablet/ext_tx_base.h @@ -2,8 +2,9 @@ #include #include -namespace NKikimr::NOlap::NDataSharing { +namespace NKikimr::NColumnShard { +//Base class for LocalDB transactions with ColumnShard specific template class TExtendedTransactionBase: public NTabletFlatExecutor::TTransactionBase { private: @@ -32,4 +33,4 @@ class TExtendedTransactionBase: public NTabletFlatExecutor::TTransactionBase -#include +#include #include @@ -77,9 +77,9 @@ class TEvWriteCommitPrimaryTransactionOperator: public TEvWriteCommitSyncTransac virtual TString DoDebugString() const override { return "EV_WRITE_PRIMARY"; } - class TTxWriteReceivedBrokenFlag: public NOlap::NDataSharing::TExtendedTransactionBase { + class TTxWriteReceivedBrokenFlag: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const ui64 TxId; const ui64 TabletId; const bool BrokenFlag; @@ -126,9 +126,9 @@ class TEvWriteCommitPrimaryTransactionOperator: public TEvWriteCommitSyncTransac return std::make_unique(owner, GetTxId(), sendTabletId, broken); } - class TTxWriteReceivedResultAck: public NOlap::NDataSharing::TExtendedTransactionBase { + class TTxWriteReceivedResultAck: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const ui64 TxId; const ui64 TabletId; @@ -222,9 +222,9 @@ class TEvWriteCommitPrimaryTransactionOperator: public TEvWriteCommitSyncTransac CheckFinished(owner); } - class TTxStartPreparation: public NOlap::NDataSharing::TExtendedTransactionBase { + class TTxStartPreparation: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const ui64 TxId; virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const NActors::TActorContext& /*ctx*/) override { diff --git a/ydb/core/tx/columnshard/transactions/operators/ev_write/secondary.h b/ydb/core/tx/columnshard/transactions/operators/ev_write/secondary.h index f60d7c0b2f4b..e6f0ab4fa3c2 100644 --- a/ydb/core/tx/columnshard/transactions/operators/ev_write/secondary.h +++ b/ydb/core/tx/columnshard/transactions/operators/ev_write/secondary.h @@ -3,7 +3,7 @@ #include "sync.h" #include -#include +#include namespace NKikimr::NColumnShard { @@ -58,9 +58,9 @@ class TEvWriteCommitSecondaryTransactionOperator: public TEvWriteCommitSyncTrans virtual TString DoDebugString() const override { return "EV_WRITE_SECONDARY"; } - class TTxWriteReceivedAck: public NOlap::NDataSharing::TExtendedTransactionBase { + class TTxWriteReceivedAck: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const ui64 TxId; bool NeedContinueFlag = false; @@ -99,9 +99,9 @@ class TEvWriteCommitSecondaryTransactionOperator: public TEvWriteCommitSyncTrans return std::make_unique(owner, GetTxId()); } - class TTxWriteReceivedBrokenFlag: public NOlap::NDataSharing::TExtendedTransactionBase { + class TTxWriteReceivedBrokenFlag: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const ui64 TxId; const bool BrokenFlag; @@ -170,9 +170,9 @@ class TEvWriteCommitSecondaryTransactionOperator: public TEvWriteCommitSyncTrans } } - class TTxStartPreparation: public NOlap::NDataSharing::TExtendedTransactionBase { + class TTxStartPreparation: public TExtendedTransactionBase { private: - using TBase = NOlap::NDataSharing::TExtendedTransactionBase; + using TBase = TExtendedTransactionBase; const ui64 TxId; virtual bool DoExecute(NTabletFlatExecutor::TTransactionContext& txc, const NActors::TActorContext& /*ctx*/) override {