Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI databases page could return "Parameters state and code are invalid" #4595

Open
StekPerepolnen opened this issue May 16, 2024 · 1 comment
Open

UI databases page could return "Parameters state and code are invalid" #4595

StekPerepolnen opened this issue May 16, 2024 · 1 comment
Assignees
@StekPerepolnen
Labels
improvement

Comments

@StekPerepolnen
Copy link
Collaborator

StekPerepolnen commented May 16, 2024 •
edited
Loading

... but people expect redirection on auth.

It seems that Embedded UI page get 400 instead of 401
https://github.com/ydb-platform/ydb-embedded-ui/blame/2dbf0f028e7690bd9cf86be5368af3d8638dffcb/src/store/configureStore.ts#L75

so, if change oidc_proxy response on 401 probably will work - needs tests
https://github.com/ydb-platform/ydb/blob/main/ydb/mvp/oidc_proxy/oidc_session_create.h#L155
@StekPerepolnen StekPerepolnen self-assigned this May 16, 2024
@StekPerepolnen StekPerepolnen added bug Something isn't working improvement and removed bug Something isn't working labels May 16, 2024
@StekPerepolnen StekPerepolnen mentioned this issue May 17, 2024
Merged
@StekPerepolnen
Copy link
Collaborator Author

#4641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StekPerepolnen StekPerepolnen

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StekPerepolnen