Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Yandex-specific logic to identify the data center and rack of the server #125

Closed
zinal opened this issue Oct 26, 2022 · 1 comment · Fixed by #688
Closed

Remove Yandex-specific logic to identify the data center and rack of the server #125

zinal opened this issue Oct 26, 2022 · 1 comment · Fixed by #688
Labels
area/security Security related features and issues

Comments

@zinal
Copy link
Member

zinal commented Oct 26, 2022

Currently YDB open source includes the logic to automatically identify the data center, rack and logical cluster name of the server, based on the specifics of the internal Yandex infrastructure.
This logic makes no sense for other users, and causes unneeded HTTP requests to Yandex API servers, so it should be removed.

The related code is currently at https://github.com/ydb-platform/ydb/blob/main/ydb/core/actorlib_impl/node_identifier.cpp#L67
@alexv-smirnov
Copy link
Member

KIKIMR-16509

@alexv-smirnov alexv-smirnov added the area/security Security related features and issues label Feb 2, 2023
@ijon ijon linked a pull request Dec 29, 2023 that will close this issue
Remove node identifier (deprecated) #688
Merged
@ijon ijon mentioned this issue Dec 29, 2023
Merged
@ijon ijon closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/security Security related features and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove node identifier (deprecated) ijon/ydb
3 participants
@ijon @zinal @alexv-smirnov