From 1a88bb4d488181d0601e076821ac3a463c61aa84 Mon Sep 17 00:00:00 2001 From: VPolka <39378135+VPolka@users.noreply.github.com> Date: Mon, 26 Aug 2024 14:41:48 +0200 Subject: [PATCH] return implicit query params type into feature flag (#8063) --- ydb/core/kqp/session_actor/kqp_query_state.h | 4 +++- ydb/core/protos/feature_flags.proto | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ydb/core/kqp/session_actor/kqp_query_state.h b/ydb/core/kqp/session_actor/kqp_query_state.h index 46749c8f8525..57452a658fe8 100644 --- a/ydb/core/kqp/session_actor/kqp_query_state.h +++ b/ydb/core/kqp/session_actor/kqp_query_state.h @@ -67,7 +67,9 @@ class TKqpQueryState : public TNonCopyable { , StartedAt(startedAt) { RequestEv.reset(ev->Release().Release()); - if (tableServiceConfig.GetEnableImplicitQueryParameterTypes() && !RequestEv->GetYdbParameters().empty()) { + bool enableImplicitQueryParameterTypes = tableServiceConfig.GetEnableImplicitQueryParameterTypes() || + AppData()->FeatureFlags.GetEnableImplicitQueryParameterTypes(); + if (enableImplicitQueryParameterTypes && !RequestEv->GetYdbParameters().empty()) { QueryParameterTypes = std::make_shared>(); for (const auto& [name, typedValue] : RequestEv->GetYdbParameters()) { QueryParameterTypes->insert({name, typedValue.Gettype()}); diff --git a/ydb/core/protos/feature_flags.proto b/ydb/core/protos/feature_flags.proto index a413b61e5cb4..dbc6133ac715 100644 --- a/ydb/core/protos/feature_flags.proto +++ b/ydb/core/protos/feature_flags.proto @@ -105,7 +105,7 @@ message TFeatureFlags { optional bool EnableSeparationComputeActorsFromRead = 90 [default = false]; optional bool EnablePQConfigTransactionsAtSchemeShard = 91 [default = false]; optional bool EnableScriptExecutionOperations = 92 [default = true]; - reserved 93; // optional bool EnableImplicitQueryParameterTypes = 93 [default = false]; + optional bool EnableImplicitQueryParameterTypes = 93 [default = false]; optional bool EnableForceImmediateEffectsExecution = 94 [default = false]; optional bool EnableTopicSplitMerge = 95 [default = false]; optional bool EnableChangefeedDynamoDBStreamsFormat = 96 [default = true];