Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use VirtualTable in Nodes and Diagnostics #678

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jan 31, 2024

VirtualTable now is used for Node pages and Diagnostics Nodes and Storage tab (previously it was used only for Cluster tabs)

Updated UI can be reviewed here: https://nda.ya.ru/t/zALAQfCs74VVEv

Ensure that experiment "Use table with data load on scroll for Nodes and Storage tabs" is turned on before reviewing this table

@artemmufazalov artemmufazalov force-pushed the virtual-table-for-all-tabs branch 2 times, most recently from b26c9ec to 73ea14a Compare January 31, 2024 10:11
@artemmufazalov artemmufazalov force-pushed the virtual-table-for-all-tabs branch from 73ea14a to f2c25ff Compare January 31, 2024 11:43
@artemmufazalov artemmufazalov marked this pull request as ready for review January 31, 2024 11:48
Copy link
Contributor

@Raubzeug Raubzeug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I switch between Nodes and Storage tabs, it is always revoked 2 similar request.

@artemmufazalov
Copy link
Member Author

When I switch between Nodes and Storage tabs, it is always revoked 2 similar request.

This issue was addressed here: #676

@Raubzeug
Copy link
Contributor

Raubzeug commented Feb 1, 2024

When I switch between Nodes and Storage tabs, it is always revoked 2 similar request.

This issue was addressed here: #676

Agrh, I always forget abt it >_<

@artemmufazalov artemmufazalov force-pushed the virtual-table-for-all-tabs branch from f2c25ff to 7260607 Compare February 5, 2024 10:39
@artemmufazalov artemmufazalov merged commit 9158050 into main Feb 5, 2024
4 checks passed
@artemmufazalov artemmufazalov deleted the virtual-table-for-all-tabs branch February 5, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable VirtualTable for Nodes and Storage tabs in Diagnostics and Node pages
2 participants