fix: make file and git dependencies work #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybiquitous
approved these changes
Jul 4, 2020
There was a problem hiding this comment.
@JakeChampion I really really appreciate your contribution! This change looks good to me. 🥰
|
Woohoo! Thanks for reviewing and releasing so swiftly @ybiquitous, I appreciate that very much 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a dependency using the
file:,git:, orgithub:protocols then this action fails to work becausenpm viewwill return a 404 for the dependency.This is a link to a project which uses the
github:protocol and shows the action failing to run -- https://github.com/Financial-Times/origami-component-converter/runs/832695920?check_suite_focus=trueMy patch makes the github action ignore 404 errors and to surface other errors with their corresponding error message instead of just the exit code.