From 9cb0057c2799b34d907c8385042cd40dcd8ad7e9 Mon Sep 17 00:00:00 2001 From: Masafumi Koba <473530+ybiquitous@users.noreply.github.com> Date: Fri, 2 Aug 2024 00:59:44 +0900 Subject: [PATCH] feat(typescript)!: require `@typescript-eslint/eslint-plugin>=8.0.0` as peer dependency (#1339) --- package-lock.json | 2 +- package.json | 2 +- rules/plugins/typescript.js | 2 -- test/e2e.test.js | 7 ++++++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index c07ceff6..f30a4c10 100644 --- a/package-lock.json +++ b/package-lock.json @@ -35,7 +35,7 @@ "node": ">=18.0.0" }, "peerDependencies": { - "@typescript-eslint/eslint-plugin": "^8.0.0", + "@typescript-eslint/eslint-plugin": ">=8.0.0", "eslint": ">=8.50.0" }, "peerDependenciesMeta": { diff --git a/package.json b/package.json index a31572f8..d3ec3c26 100644 --- a/package.json +++ b/package.json @@ -47,7 +47,7 @@ "ybiq": "^17.4.0" }, "peerDependencies": { - "@typescript-eslint/eslint-plugin": ">=7.4.0 <8.0.0", + "@typescript-eslint/eslint-plugin": ">=8.0.0", "eslint": ">=8.50.0" }, "peerDependenciesMeta": { diff --git a/rules/plugins/typescript.js b/rules/plugins/typescript.js index 26554373..e0c4a337 100644 --- a/rules/plugins/typescript.js +++ b/rules/plugins/typescript.js @@ -30,8 +30,6 @@ module.exports = { "@typescript-eslint/explicit-module-boundary-types": "warn", "@typescript-eslint/init-declarations": "off", "@typescript-eslint/key-spacing": "off", - "lines-between-class-members": "off", - "@typescript-eslint/lines-between-class-members": "error", // eslint-disable-line sort-keys "max-params": "off", "@typescript-eslint/max-params": "warn", // eslint-disable-line sort-keys "@typescript-eslint/member-ordering": "off", diff --git a/test/e2e.test.js b/test/e2e.test.js index d61a68ca..ee408c80 100644 --- a/test/e2e.test.js +++ b/test/e2e.test.js @@ -62,7 +62,12 @@ test("End-to-End", () => { const runTest = (/** @type {string} */ file) => { const configName = `ybiquitous/${path.basename(file, ".js")}`; if (configName.endsWith("/typescript")) { - outFile("tsconfig.json", JSON.stringify({ compilerOptions: { strict: true } })); + outFile( + "tsconfig.json", + JSON.stringify({ + compilerOptions: { checkJs: true, noEmit: true, strict: true }, + }), + ); writeESLintConfig({ extends: configName, parserOptions: {