Skip to content

Commit

Permalink
feat(typescript)!: require @typescript-eslint/eslint-plugin>=8.0.0
Browse files Browse the repository at this point in the history
…as peer dependency (#1339)
  • Loading branch information
ybiquitous committed Aug 1, 2024
1 parent 20cd09b commit 9cb0057
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"ybiq": "^17.4.0"
},
"peerDependencies": {
"@typescript-eslint/eslint-plugin": ">=7.4.0 <8.0.0",
"@typescript-eslint/eslint-plugin": ">=8.0.0",
"eslint": ">=8.50.0"
},
"peerDependenciesMeta": {
Expand Down
2 changes: 0 additions & 2 deletions rules/plugins/typescript.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ module.exports = {
"@typescript-eslint/explicit-module-boundary-types": "warn",
"@typescript-eslint/init-declarations": "off",
"@typescript-eslint/key-spacing": "off",
"lines-between-class-members": "off",
"@typescript-eslint/lines-between-class-members": "error", // eslint-disable-line sort-keys
"max-params": "off",
"@typescript-eslint/max-params": "warn", // eslint-disable-line sort-keys
"@typescript-eslint/member-ordering": "off",
Expand Down
7 changes: 6 additions & 1 deletion test/e2e.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ test("End-to-End", () => {
const runTest = (/** @type {string} */ file) => {
const configName = `ybiquitous/${path.basename(file, ".js")}`;
if (configName.endsWith("/typescript")) {
outFile("tsconfig.json", JSON.stringify({ compilerOptions: { strict: true } }));
outFile(
"tsconfig.json",
JSON.stringify({
compilerOptions: { checkJs: true, noEmit: true, strict: true },
}),
);
writeESLintConfig({
extends: configName,
parserOptions: {
Expand Down

0 comments on commit 9cb0057

Please sign in to comment.