Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separated commands, each commands have a separate module. Handled errors as well #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asharma991
Copy link

@asharma991 asharma991 commented Oct 2, 2023

Closes #1

@yashrajb yashrajb self-requested a review October 3, 2023 10:31
@yashrajb
Copy link
Owner

yashrajb commented Oct 4, 2023

@asharma991 did you tested properly in your local system?

@asharma991
Copy link
Author

Yes lint is passing and the build is getting generated.

@asharma991
Copy link
Author

Just now checked by launching the extension locally, and it works fine. I have a suggestion though, we should ask for username first and then the token

@yashrajb
Copy link
Owner

yashrajb commented Oct 5, 2023

@asharma991 did you tested all functionality?

@asharma991
Copy link
Author

Yes I did. I'm able to create new files and save them to github. I'm able to save the changes as well

@asharma991
Copy link
Author

Hey @yashrajb , can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code of commands is not maintainable and scalable
2 participants