-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extraneous "unmet peer dependency" warning #4595
Comments
I think have a similar problem:
but I do have |
I think this will be fixed by #4613. I tried to reproduce this locally with the patch applied and wasn't able to. |
I can't repro either on latest master @OliverJAsh can you try one of the nightly builds? https://yarnpkg.com/en/docs/nightly |
also have a problem where a package says that it has unmet peer dependency , but the dependency is installed, I thought this was fixed in 1.2 |
A changelog would help users find out whether a certain bug is fixed or not, but there is no changelog. |
The issue as reported in the OP looks fixed to me in latest yarn (1.2.1), so this can be closed.
There are likely multiple causes, could you file a new issue with full STR? :-) |
Yeah, I've also verified that I cannot repro this on latest master (post 1.2.1) so closing. |
if it is fixed, what am I doing wrong?
file-loader is installed |
|
I get the same warnings:
My package.json looks like this: {
"name": "example_app",
"private": true,
"dependencies": {
"@rails/webpacker": "^3.0.2",
"coffeescript": "^2.0.2",
"vue": "^2.5.2",
"vue-loader": "^13.3.0",
"vue-template-compiler": "^2.5.2",
},
"devDependencies": {
"webpack-dev-server": "^2.9.4"
}
} |
@phlegx I was able to fix it after some guessing... I'm new to yarn but fixed 4 warnings including the one here.
I'll list my fixes individually so you can see the pattern:
Be sure to use the appropriate dependency flags referenced in the warning, more info here: After I ran those lines... I got what I spent hours trying to achieve... 0 warnings 😄 :
|
Node 8.1.4, Yarn 1.1.0
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.
ix
has a peer dependency oftslib@^1.7.1
: https://github.com/ReactiveX/IxJS/blob/71277717f15bdf100218252326a2c95ea05d4b8a/package.json#L52This peer dependency has been met, however,
yarn
warns that this has not been met:I believe the issue only occurs when another dependency shares the peer dependency but as a normal dependency instead, as it the case with tslint, which depends on
tslib@^1.7.1
: https://github.com/palantir/tslint/blob/5ffec0910ff32e4b402859851822b1d1fe8eb3cf/package.json#L48The text was updated successfully, but these errors were encountered: