Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn upgrade gives different lock file randomly #2467

Closed
blixt opened this issue Jan 16, 2017 · 2 comments
Closed

yarn upgrade gives different lock file randomly #2467

blixt opened this issue Jan 16, 2017 · 2 comments
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+.

Comments

@blixt
Copy link

blixt commented Jan 16, 2017

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

If I run yarn upgrade repeatedly, I sometimes get the result that one dependency changed (correct behavior), sometimes I get a lot of dependencies removed (not expected).

If the current behavior is a bug, please provide the steps to reproduce.

I've put the two states in this gist: https://gist.github.com/blixt/364ab638488560c87c4348f3bc4b35ca

The files in the gist are attempt1.diff, attempt1.lock, attempt2.diff and attempt2.lock. I put the diffs in there for making it easier to see the difference. They're the diff from the state of my repo from last time dependencies changed. Only one dependency really changed (object-assign) but as you can see in attempt1.diff it removed a bunch of dependencies.

What is the expected behavior?

The same result every time I run yarn upgrade (assuming external dependencies weren't changed in the meantime).

Please mention your node.js, yarn and operating system version.

  • Node.js 7.4.0
  • Yarn 0.18.1
  • macOS 10.12.2 (16C67)
@blixt
Copy link
Author

blixt commented Jan 17, 2017

I just retested this with 0.19.1 and in about 1/10 times I get the following diff after running yarn upgrade (the other times I get a clean diff because no dependencies really changed):

https://gist.github.com/blixt/ccfbc8ebea437e3d6109bc28ea8059cb

@paul-soporan
Copy link
Member

Closing as fixed in the v2.

https://yarnpkg.com/getting-started/migration

@paul-soporan paul-soporan added the fixed-in-modern This issue has been fixed / implemented in Yarn 2+. label Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-modern This issue has been fixed / implemented in Yarn 2+.
Projects
None yet
Development

No branches or pull requests

2 participants