Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple packages: branches or folders? #2

Closed
juanca opened this issue Mar 17, 2017 · 3 comments
Closed

Multiple packages: branches or folders? #2

juanca opened this issue Mar 17, 2017 · 3 comments

Comments

@juanca
Copy link
Contributor

juanca commented Mar 17, 2017

Motivation: I'm thinking of adding a couple of test packages.

Discussion: If this repository is used to host multiple git protocol packages, should these be in different branches or folders?

Assuming it is decided to use different branches: it is difficult (perhaps impossible) to submit a new pull request from a forked repo into a non-existent branch in yarnpkg/e2e-test-repo. However, perhaps these issues could be used to request for a new branch (or some other means).

Assuming it is decided to use folders: current tests in yarnpkg/yarn will require a concurrent refactor to point to the appropriate folder.

@bestander
Copy link
Member

Sure, go ahead and send PR.
This is a throwaway test repo, so use branches and folders as you like.

@juanca
Copy link
Contributor Author

juanca commented Apr 30, 2017

I was not able to figure out how to use folders as packages. I figure a git repository can have many published packages. But it seems that yarn (and probably npm?) does not support many packages in a git repository.

For example:

Setting a remote source to https://github.com/juanca/e2e-test-repo/tree/packages-as-folders/yarn-test-git-repo throws an error with:

(node:8430) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Error: https://github.com/juanca/e2e-t
est-repo/tree/packages-as-folders/yarn-test-git-repo: Request failed "406 Not Acceptable"
    at Request.handleRequestError (/Users/juanca/workspace/yarn/src/fetchers/tarball-fetcher.js:154:20)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at Request.Object.<anonymous>.Request.onRequestResponse (/Users/juanca/workspace/yarn/node_modules/request/request.js:1074:10)
    at emitOne (events.js:101:20)
    at ClientRequest.emit (events.js:188:7)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:473:21)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:99:23)
    at TLSSocket.socketOnData (_http_client.js:362:20)
    at emitOne (events.js:101:20)

Perhaps I should post this elsewhere but should yarn support this? (I mean, it would be nice, but it would involve more work than expected).

@bestander
Copy link
Member

Opening an RFC could be a good first step.
Not sure about technical limitations but in some cases it could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants