Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: fix example of "halt-at-non-option" #165

Merged
merged 1 commit into from
May 5, 2019
Merged

README: fix example of "halt-at-non-option" #165

merged 1 commit into from
May 5, 2019

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Mar 25, 2019

Description

closes #159

The example of "halt-at-non-option" is incorrect.

If disabled: node example.js -a run b -x y

  • actual: { _: [ 'run', 'b', 'y' ], a: true, x: true }
  • correct: { _: [ 'b' ], a: 'run', x: 'y' }

If enabled: node example.js -a run b -x y

  • actual: { _: [ 'run', 'b', '-x', 'y' ], a: true }
  • correct: { _: [ 'b', '-x', 'y' ], a: 'run' }

@bcoe bcoe merged commit b1012f8 into yargs:master May 5, 2019
@bcoe
Copy link
Member

bcoe commented May 5, 2019

@juergba thank you! I will work on getting your other contributions reviewed ASAP.

@juergba juergba deleted the issue/159 branch May 5, 2019 11:35
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

halt-at-non-option example needs to include{boolean: ['a']}
2 participants
@juergba @bcoe