From dec82d142f85fcfcb28b7db8bd686729f89c0e78 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 7 Sep 2023 20:25:33 +0200 Subject: [PATCH] build(deps): bump three from 0.155.0 to 0.156.1 (#1191) * build(deps): bump three from 0.155.0 to 0.156.1 Bumps [three](https://github.com/mrdoob/three.js) from 0.155.0 to 0.156.1. - [Release notes](https://github.com/mrdoob/three.js/releases) - [Commits](https://github.com/mrdoob/three.js/commits) --- updated-dependencies: - dependency-name: three dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] * Fix remove method extended from Object3d --------- Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Niechaj --- package-lock.json | 14 +++++++------- package.json | 2 +- .../Simulation/Base/SimulationContainer.ts | 7 ++++--- src/ThreeEditor/Simulation/Zones/ZoneManager.ts | 6 +++--- 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/package-lock.json b/package-lock.json index b52906d98..eb7458676 100644 --- a/package-lock.json +++ b/package-lock.json @@ -48,7 +48,7 @@ "set-interval-async": "^3.0.3", "signals": "^1.0.0", "split-grid": "^1.0.11", - "three": "^0.155.0", + "three": "^0.156.1", "throttle-debounce": "^5.0.0", "typescript": "^5.2.2", "use-interval": "^1.4.0", @@ -20608,9 +20608,9 @@ "integrity": "sha512-N+8UisAXDGk8PFXP4HAzVR9nbfmVJ3zYLAWiTIoqC5v5isinhr+r5uaO8+7r3BMfuNIufIsA7RdpVgacC2cSpw==" }, "node_modules/three": { - "version": "0.155.0", - "resolved": "https://registry.npmjs.org/three/-/three-0.155.0.tgz", - "integrity": "sha512-sNgCYmDijnIqkD/bMfk+1pHg3YzsxW7V2ChpuP6HCQ8NiZr3RufsXQr8M3SSUMjW4hG+sUk7YbyuY0DncaDTJQ==" + "version": "0.156.1", + "resolved": "https://registry.npmjs.org/three/-/three-0.156.1.tgz", + "integrity": "sha512-kP7H0FK9d/k6t/XvQ9FO6i+QrePoDcNhwl0I02+wmUJRNSLCUIDMcfObnzQvxb37/0Uc9TDT0T1HgsRRrO6SYQ==" }, "node_modules/throat": { "version": "6.0.2", @@ -37000,9 +37000,9 @@ "integrity": "sha512-N+8UisAXDGk8PFXP4HAzVR9nbfmVJ3zYLAWiTIoqC5v5isinhr+r5uaO8+7r3BMfuNIufIsA7RdpVgacC2cSpw==" }, "three": { - "version": "0.155.0", - "resolved": "https://registry.npmjs.org/three/-/three-0.155.0.tgz", - "integrity": "sha512-sNgCYmDijnIqkD/bMfk+1pHg3YzsxW7V2ChpuP6HCQ8NiZr3RufsXQr8M3SSUMjW4hG+sUk7YbyuY0DncaDTJQ==" + "version": "0.156.1", + "resolved": "https://registry.npmjs.org/three/-/three-0.156.1.tgz", + "integrity": "sha512-kP7H0FK9d/k6t/XvQ9FO6i+QrePoDcNhwl0I02+wmUJRNSLCUIDMcfObnzQvxb37/0Uc9TDT0T1HgsRRrO6SYQ==" }, "throat": { "version": "6.0.2", diff --git a/package.json b/package.json index ec6f6298a..b761152d6 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "set-interval-async": "^3.0.3", "signals": "^1.0.0", "split-grid": "^1.0.11", - "three": "^0.155.0", + "three": "^0.156.1", "throttle-debounce": "^5.0.0", "typescript": "^5.2.2", "use-interval": "^1.4.0", diff --git a/src/ThreeEditor/Simulation/Base/SimulationContainer.ts b/src/ThreeEditor/Simulation/Base/SimulationContainer.ts index 514f3e77b..ca00d59b7 100644 --- a/src/ThreeEditor/Simulation/Base/SimulationContainer.ts +++ b/src/ThreeEditor/Simulation/Base/SimulationContainer.ts @@ -49,9 +49,10 @@ export abstract class SimulationSceneContainer< return result; } - remove(child: TChild): this { - const result = super.remove(child); - this.editor.signals.objectRemoved.dispatch(child); + remove(...children: TChild[]): this { + const result = super.remove(...children); + + for (const child of children) this.editor.signals.objectRemoved.dispatch(child); return result; } diff --git a/src/ThreeEditor/Simulation/Zones/ZoneManager.ts b/src/ThreeEditor/Simulation/Zones/ZoneManager.ts index 40f6a946e..9d55fa367 100644 --- a/src/ThreeEditor/Simulation/Zones/ZoneManager.ts +++ b/src/ThreeEditor/Simulation/Zones/ZoneManager.ts @@ -33,10 +33,10 @@ export class ZoneContainer extends SimulationSceneContainer { super(editor, 'Zones', 'ZoneGroup', zoneLoader(editor)); } - remove(zone: SimulationZone): this { - zone.simulationMaterial.decrement(); + remove(...zones: SimulationZone[]): this { + for (const zone of zones) zone.simulationMaterial.decrement(); - return super.remove(zone); + return super.remove(...zones); } // eslint-disable-next-line class-methods-use-this