skipShapeProps should be enabled by default until it works properly

[everdimension]

The option no-unused-prop-types doesn't work properly for shape proptypes in lots of popular cases: #851, #819 and other cases, like when used outside of the component class.

This causes very annoying inconviences.

So currently the option only works without problems if the skipShapeProps is set to true. Therefore it's best to skip linting shape props by default until the mentioned problems are fixed and setting this option to false actually becomes useful.

[ljharb]

Actually I think this is probably a good change. @yannickcr?

[everdimension]

@ljharb yea, I planned to fix the failing checks and then reopen the pr. Perhaps a bit later today.

[everdimension]

@ljharb, @yannickcr Updated the PR

[yannickcr]

Seems the rule is not working properly if theskipShapeProps option is set to false, so is it useful to keep this option?

[everdimension]

@yannickcr Well, it does work for simple cases (which are in tests) so it might be enough for someone's writing style.
And hopefully it will once work just as expected for all other cases, too.

[yannickcr]

@everdimension I see. But in this case passing this option to true by default is a breaking change, so it should be done in a major release.

[ljharb]

@yannickcr why is it a breaking change? Setting that default causes fewer errors, so by eslint's semver policy that's just a patch.

[yannickcr]

@ljharb Ho, you're right. LGTM then :)