Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tab indentation #909

Merged
merged 6 commits into from
Oct 12, 2016
Merged

Support tab indentation #909

merged 6 commits into from
Oct 12, 2016

Conversation

arperry
Copy link
Contributor

@arperry arperry commented Oct 12, 2016

The autofix for this rule substitutes spaces even when the code is normally indented with tabs. This change accommodates tabs, spaces, and even mixed whitespace (we won't judge).

The autofix for this rule substitutes spaces even when the code is normally indented with tabs. This change accommodates tabs, spaces, and even mixed whitespace (we won't judge).
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide tests for this?

@arperry
Copy link
Contributor Author

arperry commented Oct 12, 2016

Tests added.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lencioni
Copy link
Collaborator

Thanks!

@lencioni lencioni merged commit c056489 into jsx-eslint:master Oct 12, 2016
@arperry arperry deleted the patch-1 branch October 12, 2016 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants