Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSXExpressionContainer support for jsx-indent rule #838

Merged
merged 2 commits into from
Sep 16, 2016
Merged

Add JSXExpressionContainer support for jsx-indent rule #838

merged 2 commits into from
Sep 16, 2016

Conversation

eelyafi
Copy link
Contributor

@eelyafi eelyafi commented Sep 15, 2016

Right now jsx-indent linter won't catch cases like:

<App>
   {test}
</App>

This diff will add support for JSXExpressionContainer

ljharb
ljharb requested changes Sep 16, 2016
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add some tests for tabs?

eelyafi
eelyafi commented Sep 16, 2016
View reviewed changes
Copy link
Contributor Author

@eelyafi eelyafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests for tabs

@eelyafi
Copy link
Contributor Author

eelyafi commented Sep 16, 2016

@ljharb I've added tests for tabs

@ljharb ljharb added the bug label Sep 16, 2016
@lencioni
Copy link
Collaborator

LGTM, thanks!

@lencioni lencioni merged commit f0fd75b into jsx-eslint:master Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

@yannickcr yannickcr

@lencioni lencioni

Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eelyafi @lencioni @ljharb @yannickcr