[Fix] In require-optimization corrected test for function declaration

[Tom910]

There was a problem with the ad functions and methods in classes, sample code -

import React from "react";
class YourComponent extends React.Component {
  handleClick() {}
  render() {
     return <div onClick={this.handleClick}>123</div>;
  }
}

{
  "rules": {
    "react/require-optimization": 2  
  }
}

This code has been checked and is not output error, it is wrong

[ljharb]

should this be componentDidMount?

[Tom910]

Replace on a new example

[ljharb]

Sorry for my earlier confusion - I was confusing this with a "prefer SFCs" rule :-)

Afaik require-optimization should skip any createClass component with PureRenderMixin, and should skip any class component with a shouldComponentUpdate method, and should skip any SFC entirely.

If you have components that don't match these criteria, and require-optimization is not warning on them, then that seems like it might indeed be a bug.

[lencioni]

It should also skip classes that extend React.PureComponent.

[Tom910]

@lencioni Yes, I agree, but it has already been implemented @yannickcr commit 8b567a6

@ljharb Yes, it is =)

[yannickcr]

Merged, thanks!