Add Pragma for createClass factory method #725
Conversation
|
@yannickcr I would love to help you merge this in. I didn't see any notes on contributing to this project in the README or on the wiki. Please let me know what next steps I need to take. |
|
Thanks for your contribution. Sorry, I'm a bit busy working on the v6.0.0 right now, but I'll try to have a look on this right after 😃 |
| if (context.settings.react && context.settings.react.createClass) { | ||
| pragma = context.settings.react.createClass; | ||
| } | ||
| return pragma.split('(')[0]; |
There was a problem hiding this comment.
Why do you make a .split('(') here?
There was a problem hiding this comment.
I matched the .split('.') on line 24.
It's there because ( cannot be part of a function's name
There was a problem hiding this comment.
If someone sets an invalid pragma value, shouldn't the plugin error out, instead of trying to fix it for them?
Allows the the plugin to lint components created in a non-standard way with
configuration such as
```js
var MyComponent = React.createSpecialClass({
...
});
```
|
Ok, I added a regex and I set config to throw an error when an invalid config is given for either pragma field |
|
Merged, thanks! |
Allows the the plugin to lint components created in a non-standard way with
configuration such as
with config looking like:
{ "settings": { "react": { "createClass": "createSpecialClass", "pragma": "SpecialReact", } } }