Only mark component types as used, not prop names. #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all JSX identifiers were marked as "used", even for prop names. This is an issue in cases where component props happened by chance to have the same name as a local variable, like this:
Here, the "foo" prop prevents the
foo
variable from being marked as unused and ESLint gives no warnings for theno-unused-vars
rule, even thoughfoo
is not actually referenced anywhere.This change updates the
jsx-uses-vars
rule to only mark variables as used if they occur in aJSXOpeningElement
node (thus excluding prop names, as they exist inJSXAttribute
nodes instead).