Autofix for jsx-closing-bracket-location. #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'var x = function() {', | ||
| ' return <App', | ||
| ' foo', | ||
| '/>', |
There was a problem hiding this comment.
I think it should be aligned with the return keyword in this case.
|
Thanks for this! I think there is a small issue in a test case though. |
|
@yannickcr - Thank you for taking a look. I've fixed the test case and resolved this by walking up nodes until it finds one that it's looking for. Commit is here: 0f9ff7f Please let me know if there's a better way of doing this, or if there's anything else you'd like to see here. Thanks! |
|
Great! Can you squash your commits? Then I think we'll be good to go :) |
KevinGrandon
force-pushed
the
closing_bracket_autofix
branch
from
0f9ff7f
to
deb8e4e
Compare
|
This is now squashed, thanks! |
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yannickcr - I'm fairly new to eslint and the inner workings of this so this could be wrong, or there could be better ways of doing things. Let me know what you think, thanks!