Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive with display-name rule #996

Closed
nt1m opened this issue Dec 9, 2016 · 0 comments
Closed

False positive with display-name rule #996

nt1m opened this issue Dec 9, 2016 · 0 comments
Labels
accepted bug help wanted

Comments

@nt1m
Copy link

nt1m commented Dec 9, 2016

Seems like this: document.createElement makes the rule believe you're using React.createElement:

https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/new-console-output/test/fixtures/serviceContainer.js#16
jomasti added a commit to jomasti/eslint-plugin-react that referenced this issue Jan 2, 2017
@jomasti
Check for createElement being called from React
c6264d0 
Fixes jsx-eslint#996. This will prevent document.createElement triggering a
false positive for react/display-name.
@jomasti jomasti mentioned this issue Jan 2, 2017
Merged
This was referenced Sep 22, 2018
Closed
Closed
@renovate renovate bot mentioned this issue Oct 25, 2018
Merged
@renovate renovate bot mentioned this issue Dec 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted bug help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @nt1m