Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Allow react/sort-prop-types to only sort by callbacks and required properties and not alphabetically #786

Closed
HenriBeck opened this issue Aug 26, 2016 · 2 comments
Closed

Proposal: Allow react/sort-prop-types to only sort by callbacks and required properties and not alphabetically #786

HenriBeck opened this issue Aug 26, 2016 · 2 comments
Labels
enhancement

Comments

@HenriBeck
Copy link

HenriBeck commented Aug 26, 2016 •
edited
Loading

Proposal

Add another option to sort-prop-types called noSortAlphabetically that will allow disabling sorting the props by alphabet when the user wants it.

I would be happy to create a pull request.
@HenriBeck HenriBeck mentioned this issue Aug 26, 2016
Closed
@ljharb
Copy link
Member

ljharb commented Aug 26, 2016

Or, alternatively, noSortAlphabetically - boolean option absence, and a value of false, should always have the same effect.

@HenriBeck
Copy link
Author

HenriBeck commented Aug 26, 2016 •
edited
Loading

Probably would even be better for better backward compatibility.

@HenriBeck HenriBeck mentioned this issue Aug 28, 2016
Closed
@lencioni lencioni mentioned this issue Sep 16, 2016
Closed
markus101 added a commit to markus101/eslint-plugin-react that referenced this issue Nov 25, 2016
@markus101
jsx-sort-props noSortAlphabetically option
340b93c 
Closes jsx-eslint#541
Closes jsx-eslint#786
@markus101 markus101 mentioned this issue Nov 25, 2016
Merged
This was referenced Sep 22, 2018
Closed
Closed
@renovate renovate bot mentioned this issue Oct 25, 2018
Merged
@renovate renovate bot mentioned this issue Dec 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @lencioni @HenriBeck