Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display-name rule quotes handling #590

Closed
kib357 opened this issue May 10, 2016 · 0 comments · Fixed by #602
Closed

display-name rule quotes handling #590

kib357 opened this issue May 10, 2016 · 0 comments · Fixed by #602

Comments

@kib357
Copy link

kib357 commented May 10, 2016

If JSON style is used for defining components, rule is not handle "displayName" option.
The following patterns are considered warnings:
var Hello = React.createClass({ "displayName": "Hello", "render": function() { return <div>Hello {this.props.name}</div>; } });
but its valid code i think.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix display-name when JSON style is used for defining components
1 participant
@kib357