Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsx-indent-props for aligned indentation #398

Closed
davegomez opened this issue Jan 17, 2016 · 2 comments
Closed

jsx-indent-props for aligned indentation #398

davegomez opened this issue Jan 17, 2016 · 2 comments

Comments

@davegomez
Copy link

davegomez commented Jan 17, 2016

It would be nice if this rule would allow to set an option to lint all the props declarations one below the other just like the next snippet shows.

<div styleName='content'>
  <TableOfContents content={props.model.tableOfContents} />
    <ContentView content={props.model.contents}
                 editing={props.model.editing}
                 actions={props.actions}
                 bind={this.props.bind} />
</div>
@ljharb
Copy link
Member

ljharb commented Jun 7, 2016

I'm going to delete these 4 +1 comments, and any further ones - please follow GitHub etiquette and express that emotion with a reaction on the original post. Thanks!

sophistifunk added a commit to jenkinsci/blueocean-plugin that referenced this issue Jan 30, 2017
…arns 4 spaces or better yet standard XML style like jsx-eslint/eslint-plugin-react#398

        CCCCCCCCCCCCC     OOOOOOOOO     MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE
     CCC::::::::::::C   OO:::::::::OO   M:::::::M             M:::::::ME::::::::::::::::::::E
   CC:::::::::::::::C OO:::::::::::::OO M::::::::M           M::::::::ME::::::::::::::::::::E
  C:::::CCCCCCCC::::CO:::::::OOO:::::::OM:::::::::M         M:::::::::MEE::::::EEEEEEEEE::::E
 C:::::C       CCCCCCO::::::O   O::::::OM::::::::::M       M::::::::::M  E:::::E       EEEEEE
C:::::C              O:::::O     O:::::OM:::::::::::M     M:::::::::::M  E:::::E
C:::::C              O:::::O     O:::::OM:::::::M::::M   M::::M:::::::M  E::::::EEEEEEEEEE
C:::::C              O:::::O     O:::::OM::::::M M::::M M::::M M::::::M  E:::::::::::::::E
C:::::C              O:::::O     O:::::OM::::::M  M::::M::::M  M::::::M  E:::::::::::::::E
C:::::C              O:::::O     O:::::OM::::::M   M:::::::M   M::::::M  E::::::EEEEEEEEEE
C:::::C              O:::::O     O:::::OM::::::M    M:::::M    M::::::M  E:::::E
 C:::::C       CCCCCCO::::::O   O::::::OM::::::M     MMMMM     M::::::M  E:::::E       EEEEEE
  C:::::CCCCCCCC::::CO:::::::OOO:::::::OM::::::M               M::::::MEE::::::EEEEEEEE:::::E
   CC:::::::::::::::C OO:::::::::::::OO M::::::M               M::::::ME::::::::::::::::::::E
     CCC::::::::::::C   OO:::::::::OO   M::::::M               M::::::ME::::::::::::::::::::E
        CCCCCCCCCCCCC     OOOOOOOOO     MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE

                                    MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE
          @@@@@@@@@                 M:::::::M             M:::::::ME::::::::::::::::::::E
        @@:::::::::@@               M::::::::M           M::::::::ME::::::::::::::::::::E
      @@:::::::::::::@@             M:::::::::M         M:::::::::MEE::::::EEEEEEEEE::::E
     @:::::::@@@:::::::@            M::::::::::M       M::::::::::M  E:::::E       EEEEEE
     @::::::@   @::::::@            M:::::::::::M     M:::::::::::M  E:::::E
     @:::::@  @@@@:::::@            M:::::::M::::M   M::::M:::::::M  E::::::EEEEEEEEEE
     @:::::@  @::::::::@            M::::::M M::::M M::::M M::::::M  E:::::::::::::::E
     @:::::@  @::::::::@            M::::::M  M::::M::::M  M::::::M  E:::::::::::::::E
     @:::::@  @:::::::@@            M::::::M   M:::::::M   M::::::M  E::::::EEEEEEEEEE
     @:::::@  @@@@@@@@              M::::::M    M:::::M    M::::::M  E:::::E
     @::::::@                       M::::::M     MMMMM     M::::::M  E:::::E       EEEEEE
     @:::::::@@@@@@@@               M::::::M               M::::::MEE::::::EEEEEEEE:::::E
      @@:::::::::::::@              M::::::M               M::::::ME::::::::::::::::::::E
        @@:::::::::::@              M::::::M               M::::::ME::::::::::::::::::::E
          @@@@@@@@@@@               MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE

        BBBBBBBBBBBBBBBBB   RRRRRRRRRRRRRRRRR        OOOOOOOOO        SSSSSSSSSSSSSSS
        B::::::::::::::::B  R::::::::::::::::R     OO:::::::::OO    SS:::::::::::::::S
        B::::::BBBBBB:::::B R::::::RRRRRR:::::R  OO:::::::::::::OO S:::::SSSSSS::::::S
        BB:::::B     B:::::BRR:::::R     R:::::RO:::::::OOO:::::::OS:::::S     SSSSSSS
          B::::B     B:::::B  R::::R     R:::::RO::::::O   O::::::OS:::::S
          B::::B     B:::::B  R::::R     R:::::RO:::::O     O:::::OS:::::S
          B::::BBBBBB:::::B   R::::RRRRRR:::::R O:::::O     O:::::O S::::SSSS
          B:::::::::::::BB    R:::::::::::::RR  O:::::O     O:::::O  SS::::::SSSSS
          B::::BBBBBB:::::B   R::::RRRRRR:::::R O:::::O     O:::::O    SSS::::::::SS
          B::::B     B:::::B  R::::R     R:::::RO:::::O     O:::::O       SSSSSS::::S
          B::::B     B:::::B  R::::R     R:::::RO:::::O     O:::::O            S:::::S
          B::::B     B:::::B  R::::R     R:::::RO::::::O   O::::::O            S:::::S
        BB:::::BBBBBB::::::BRR:::::R     R:::::RO:::::::OOO:::::::OSSSSSSS     S:::::S
        B:::::::::::::::::B R::::::R     R:::::R OO:::::::::::::OO S::::::SSSSSS:::::S
        B::::::::::::::::B  R::::::R     R:::::R   OO:::::::::OO   S:::::::::::::::SS
        BBBBBBBBBBBBBBBBB   RRRRRRRR     RRRRRRR     OOOOOOOOO      SSSSSSSSSSSSSSS
sophistifunk added a commit to jenkinsci/blueocean-plugin that referenced this issue Feb 7, 2017
* Squashed commit of the following:

commit 628552d
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Fri Jan 27 18:08:48 2017 +1000

    josh/header-changes-redux-a * Clean some stuff up, fix close button in RunDetails

commit aeffbbf
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Fri Jan 27 17:26:12 2017 +1000

    josh/header-changes-redux-a * Integrate new header into run details better, fix a bunch of styling

commit fe18c70
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Tue Jan 24 20:05:18 2017 +1000

    josh/header-changes-redux-a * Animations sorted for FullScreen

commit 5aa042e
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Tue Jan 24 18:41:31 2017 +1000

    josh/header-changes-redux-a * FullScreen component working (no animation)

commit 414a042
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Mon Jan 23 17:57:41 2017 +1000

    josh/header-changes-redux-a * lint-ignore data for stories

commit 3e163e7
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Mon Jan 23 17:55:04 2017 +1000

    josh/header-changes-redux-a * Remove some redundant old code RunDetailsHeader

commit bcee830
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Mon Jan 23 17:53:29 2017 +1000

    josh/header-changes-redux-a
     * Remove redundant css refs from storybook headers
     * Update RunDetailsHeader with new ResultPageHeader component, update stories
     * Small fix to ResultPageHeader

commit 67b304a
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Fri Jan 20 15:28:37 2017 +1000

    josh/header-changes-redux-a * Republish core-js and add new version to deps

commit fb055fe
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Fri Jan 20 14:52:05 2017 +1000

    josh/header-changes-redux-a * Clean up the stories for run details header story

commit c0fbf94
Author: Josh McDonald <josh@joshmcdonald.info>
Date:   Fri Jan 20 12:42:55 2017 +1000

    Squashed commit of the following:

    commit 39d01d216b8d3abb10a0da4ac5ac8eb65824c176
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Thu Jan 19 15:32:31 2017 +1000

        .

    commit f7ff19f7fb4f6445c1a5e78cafc8b9dda585d811
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Thu Jan 19 13:52:13 2017 +1000

        josh/header-changes-redux * Publish beta of core-js again

    commit 5243cd8eb4b79b13d0af8a622bcd789fa9210e51
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Wed Jan 18 17:19:15 2017 +1000

        josh/header-changes-redux * Fix an issue in the header dealing with base url for page tabs

    commit 4caf18021c92f7e908aa4dd95514a7e6b2c53a79
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Wed Jan 18 14:29:20 2017 +1000

        josh/header-changes-redux * Apply new header to PipelinePage

    commit 54b1d04ab357d6fc89547038f5fd99d755037f9c
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Tue Jan 17 17:35:12 2017 +1000

        josh/header-changes-redux * New header for Pipelines / Dashboard screen

    commit d94e43d0756efa2fda4b8a360354e4d3714c4495
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Tue Jan 17 16:43:32 2017 +1000

        josh/header-changes-redux * Fix a typo in core-js, new beta publish

    commit 5626addfdecebc89b5f3a651dfae9b2483396567
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Tue Jan 17 13:22:19 2017 +1000

        josh/header-changes-redux * Switch to new site header

    commit 5811ed7e1b783303421e7f850c744fdb8108a791
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Tue Jan 17 11:34:17 2017 +1000

        josh/header-changes-redux * Actually export the GD new component, maybe try that? Re-publish beta, and new beta dep

    commit c9b2f10b93cda758ea8d3730e5b9aa6a4b8cda46
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Mon Jan 16 17:53:20 2017 +1000

        josh/header-changes-redux * Import beta of core-js

    commit 660bbbfb95ae16fa8cea5d95a1593de3d9511574
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Mon Jan 16 17:46:46 2017 +1000

        josh/header-changes-redux * Split page content header into site + page header components, bump version to beta

    commit d73720d16bdd3dcbe1452e0befffee4b0851b2ba
    Author: Josh McDonald <josh@joshmcdonald.info>
    Date:   Mon Jan 16 16:07:27 2017 +1000

        josh/header-changes-redux * Update to use latest release JDL

* josh/header-changes-redux-b * publish new beta of core-js

* josh/header-changes-redux-b * Pull in new beta core-js

* josh/header-changes-redux-b * Re-introduce extensionpoint hack for forcing module CSS to load

* josh/header-changes-redux-b * Add close-on-esc functionality

* josh/header-changes-redux-b * jsx-indent-props can eat it until it learns 4 spaces or better yet standard XML style like jsx-eslint/eslint-plugin-react#398

        CCCCCCCCCCCCC     OOOOOOOOO     MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE
     CCC::::::::::::C   OO:::::::::OO   M:::::::M             M:::::::ME::::::::::::::::::::E
   CC:::::::::::::::C OO:::::::::::::OO M::::::::M           M::::::::ME::::::::::::::::::::E
  C:::::CCCCCCCC::::CO:::::::OOO:::::::OM:::::::::M         M:::::::::MEE::::::EEEEEEEEE::::E
 C:::::C       CCCCCCO::::::O   O::::::OM::::::::::M       M::::::::::M  E:::::E       EEEEEE
C:::::C              O:::::O     O:::::OM:::::::::::M     M:::::::::::M  E:::::E
C:::::C              O:::::O     O:::::OM:::::::M::::M   M::::M:::::::M  E::::::EEEEEEEEEE
C:::::C              O:::::O     O:::::OM::::::M M::::M M::::M M::::::M  E:::::::::::::::E
C:::::C              O:::::O     O:::::OM::::::M  M::::M::::M  M::::::M  E:::::::::::::::E
C:::::C              O:::::O     O:::::OM::::::M   M:::::::M   M::::::M  E::::::EEEEEEEEEE
C:::::C              O:::::O     O:::::OM::::::M    M:::::M    M::::::M  E:::::E
 C:::::C       CCCCCCO::::::O   O::::::OM::::::M     MMMMM     M::::::M  E:::::E       EEEEEE
  C:::::CCCCCCCC::::CO:::::::OOO:::::::OM::::::M               M::::::MEE::::::EEEEEEEE:::::E
   CC:::::::::::::::C OO:::::::::::::OO M::::::M               M::::::ME::::::::::::::::::::E
     CCC::::::::::::C   OO:::::::::OO   M::::::M               M::::::ME::::::::::::::::::::E
        CCCCCCCCCCCCC     OOOOOOOOO     MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE

                                    MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE
          @@@@@@@@@                 M:::::::M             M:::::::ME::::::::::::::::::::E
        @@:::::::::@@               M::::::::M           M::::::::ME::::::::::::::::::::E
      @@:::::::::::::@@             M:::::::::M         M:::::::::MEE::::::EEEEEEEEE::::E
     @:::::::@@@:::::::@            M::::::::::M       M::::::::::M  E:::::E       EEEEEE
     @::::::@   @::::::@            M:::::::::::M     M:::::::::::M  E:::::E
     @:::::@  @@@@:::::@            M:::::::M::::M   M::::M:::::::M  E::::::EEEEEEEEEE
     @:::::@  @::::::::@            M::::::M M::::M M::::M M::::::M  E:::::::::::::::E
     @:::::@  @::::::::@            M::::::M  M::::M::::M  M::::::M  E:::::::::::::::E
     @:::::@  @:::::::@@            M::::::M   M:::::::M   M::::::M  E::::::EEEEEEEEEE
     @:::::@  @@@@@@@@              M::::::M    M:::::M    M::::::M  E:::::E
     @::::::@                       M::::::M     MMMMM     M::::::M  E:::::E       EEEEEE
     @:::::::@@@@@@@@               M::::::M               M::::::MEE::::::EEEEEEEE:::::E
      @@:::::::::::::@              M::::::M               M::::::ME::::::::::::::::::::E
        @@:::::::::::@              M::::::M               M::::::ME::::::::::::::::::::E
          @@@@@@@@@@@               MMMMMMMM               MMMMMMMMEEEEEEEEEEEEEEEEEEEEEE

        BBBBBBBBBBBBBBBBB   RRRRRRRRRRRRRRRRR        OOOOOOOOO        SSSSSSSSSSSSSSS
        B::::::::::::::::B  R::::::::::::::::R     OO:::::::::OO    SS:::::::::::::::S
        B::::::BBBBBB:::::B R::::::RRRRRR:::::R  OO:::::::::::::OO S:::::SSSSSS::::::S
        BB:::::B     B:::::BRR:::::R     R:::::RO:::::::OOO:::::::OS:::::S     SSSSSSS
          B::::B     B:::::B  R::::R     R:::::RO::::::O   O::::::OS:::::S
          B::::B     B:::::B  R::::R     R:::::RO:::::O     O:::::OS:::::S
          B::::BBBBBB:::::B   R::::RRRRRR:::::R O:::::O     O:::::O S::::SSSS
          B:::::::::::::BB    R:::::::::::::RR  O:::::O     O:::::O  SS::::::SSSSS
          B::::BBBBBB:::::B   R::::RRRRRR:::::R O:::::O     O:::::O    SSS::::::::SS
          B::::B     B:::::B  R::::R     R:::::RO:::::O     O:::::O       SSSSSS::::S
          B::::B     B:::::B  R::::R     R:::::RO:::::O     O:::::O            S:::::S
          B::::B     B:::::B  R::::R     R:::::RO::::::O   O::::::O            S:::::S
        BB:::::BBBBBB::::::BRR:::::R     R:::::RO:::::::OOO:::::::OSSSSSSS     S:::::S
        B:::::::::::::::::B R::::::R     R:::::R OO:::::::::::::OO S::::::SSSSSS:::::S
        B::::::::::::::::B  R::::::R     R:::::R   OO:::::::::OO   S:::::::::::::::SS
        BBBBBBBBBBBBBBBBB   RRRRRRRR     RRRRRRR     OOOOOOOOO      SSSSSSSSSSSSSSS

* josh/header-changes-redux-b * Lint (dashboard)

* Whitespace

* josh/header-changes-redux-b * Re-integrate time fixes to ResultPageHeader

* josh/header-changes-redux-b * Fix storybooks

* josh/header-changes-redux-b * lint

* josh/header-changes-redux-b * re-publish and re-import core-js beta

* josh/header-changes-redux-b * Fix scrolling issue in FullScreen component

* josh/header-changes-redux-b * re-publish core-js

* josh/header-changes-redux-b * Pull in latest JDL

* josh/header-changes-redux-b * Update JDL ref in core-js

* josh/header-changes-redux-b * Remove debugging noise

* josh/header-changes-redux-b * Changes for fixed-width headers and content for JENKINS-41547

* josh/header-changes-redux-b * Fix up some dependency inconsistencies

* josh/header-changes-redux-b * Fix to remove max-width constraints from headers when in 'modal' run dialog

* josh/header-changes-redux-b * Update JDL dependency

* josh/header-changes-redux-b * Re-do import of latest JDL, and unification of other dep versions

* josh/header-changes-redux-b * Update core-js + publish

* Updated

* josh/header-changes-redux-b * Publish new core-js w latest JDL

* josh/header-changes-redux-b * Updated to latest JDL and core-js
@klimashkin
Copy link

Currently such indentation is default one in WebStorm - it's clear and convenient.

Really want to have rule config like

'react/jsx-indent-props': [2, 2],

and for example

'react/jsx-indent-props': [2, 'tag-name'],

ThiefMaster added a commit to ThiefMaster/eslint-plugin-react that referenced this issue Mar 19, 2018
This is the default style used by the JetBrains IDEs.
closes jsx-eslint#398
ThiefMaster added a commit to ThiefMaster/eslint-plugin-react that referenced this issue Mar 19, 2018
This is the default style used by the JetBrains IDEs.
closes jsx-eslint#398
ThiefMaster added a commit to ThiefMaster/eslint-plugin-react that referenced this issue Apr 1, 2018
This is the default style used by the JetBrains IDEs.
closes jsx-eslint#398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants