Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-array-index-key rule exception #1023

Merged
merged 1 commit into from
Jan 14, 2017
Merged

Fix no-array-index-key rule exception #1023

merged 1 commit into from
Jan 14, 2017

Conversation

wKich
Copy link
Contributor

@wKich wKich commented Jan 13, 2017

No description provided.

@wKich
Copy link
Contributor Author

wKich commented Jan 13, 2017

Fix #1021

@lasergoat lasergoat mentioned this pull request Jan 13, 2017
Closed
ljharb
ljharb approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ljharb
ljharb requested changes Jan 13, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually could we add a test case for warning on { ...foo, key: index }?

@wKich
Copy link
Contributor Author

wKich commented Jan 13, 2017

Done

lencioni
lencioni approved these changes Jan 13, 2017
View reviewed changes
Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ljharb
ljharb approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks :-)

@ljharb ljharb added the bug label Jan 13, 2017
@ljharb ljharb merged commit 70d48a8 into jsx-eslint:master Jan 14, 2017
@keylocation-bot keylocation-bot mentioned this pull request Jan 15, 2017
Merged
@renovate-bot renovate-bot mentioned this pull request Feb 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lencioni lencioni lencioni approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wKich @ljharb @lencioni