Fix simple destructuring handling (fixes #137)

jsx-eslint · Jul 1, 2015 · a869bd1 · a869bd1
1 parent 824ba8d
commit a869bd1
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -385,15 +385,14 @@ module.exports = function(context) {
         }
         break;
       case 'VariableDeclarator':
-        type = 'destructuring';
-
         for (var i = 0, j = node.id.properties.length; i < j; i++) {
           if (
             (node.id.properties[i].key.name !== 'props' && node.id.properties[i].key.value !== 'props') ||
             node.id.properties[i].value.type !== 'ObjectPattern'
           ) {
             continue;
           }
+          type = 'destructuring';
           properties = node.id.properties[i].value.properties;
           break;
         }

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -538,6 +538,16 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
         '};'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  render() {',
+        '    let {firstname} = this;',
+        '    return <div>{firstname}</div>;',
+        '  }',
+        '};'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],