Fix "ignore" option for prop-types rule (fixes #135)

jsx-eslint · Jun 29, 2015 · 999e7c4 · 999e7c4
1 parent e577f76
commit 999e7c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -500,12 +500,11 @@ module.exports = function(context) {
    * @param {Object} component The component to process
    */
   function reportUndeclaredPropTypes(component) {
-    var allNames, name;
+    var allNames;
     for (var i = 0, j = component.usedPropTypes.length; i < j; i++) {
-      name = component.usedPropTypes[i].name;
       allNames = component.usedPropTypes[i].allNames;
       if (
-        isIgnored(name) ||
+        isIgnored(allNames[0]) ||
         isDeclaredInComponent(component, allNames)
       ) {
         continue;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -512,6 +512,16 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
         classes: true,
         jsx: true
       }
+    }, {
+      code: [
+        'class Hello extends React.Component {',
+        '  render() {',
+        '    return <div>{this.props.name.firstname}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      args: [1, {ignore: ['name']}]
     }
   ],