Fix props validation when using a prop as an object key (fixes #132)

jsx-eslint · Jun 28, 2015 · 84d49dc · 84d49dc
1 parent 8a50a24
commit 84d49dc
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -338,6 +338,8 @@ module.exports = function(context) {
             return '__COMPUTED_PROP__';
           }
           return property.name;
+        case 'MemberExpression':
+          return void 0;
         case 'Literal':
           // Accept computed properties that are literal strings
           if (typeof property.value === 'string') {

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -493,6 +493,25 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
         classes: true,
         jsx: true
       }
+    }, {
+      code: [
+        'var TestComp1 = React.createClass({',
+        '  propTypes: {',
+        '    size: React.PropTypes.string',
+        '  },',
+        '  render: function() {',
+        '    var foo = {',
+        '      baz: \'bar\'',
+        '    };',
+        '    var icons = foo[this.props.size].salut;',
+        '    return <div>{icons}</div>;',
+        '  }',
+        '});'
+      ].join('\n'),
+      ecmaFeatures: {
+        classes: true,
+        jsx: true
+      }
     }
   ],