hotfix for NaN comparison [CLICKHOUSE-3760] #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Broken test: 00693_max_block_size_system_tables_columns SELECT avg(blockSize()) <= 10000 FROM system.columns LIMIT 10 SETTINGS max_block_size = 10; SELECT avg(blockSize()) FROM system.columns LIMIT 10 SETTINGS max_block_size = 10; |
dbms/src/Core/AccurateComparison.h
Outdated
| @@ -409,6 +417,12 @@ inline bool_if_safe_conversion<A, B> lessOrEqualsOp(A a, B b) | |||
| template <typename A, typename B> | |||
| inline bool_if_not_safe_conversion<A, B> greaterOrEqualsOp(A a, B b) | |||
| { | |||
| if constexpr (std::is_floating_point_v<A>) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en