Add output_format_json_escape_slashes setting - controls escaping sla… #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shes for string outputs in JSON output format.
| @@ -176,7 +176,7 @@ static void writeExtremesElement(const char * title, const Block & extremes, siz | |||
| writeCString(",\n", ostr); | |||
|
|
|||
| writeCString("\t\t\t", ostr); | |||
| writeJSONString(column.name, ostr); | |||
| writeJSONString(column.name, ostr, settings); | |||
There was a problem hiding this comment.
settings are propagated not in every call to writeJSONString.
There was a problem hiding this comment.
@alexey-milovidov please have another look, should be fine now.
Also added some basic tests.
dbms/src/IO/WriteHelpers.h
Outdated
| @@ -173,7 +174,7 @@ inline void writeString(const StringRef & ref, WriteBuffer & buf) | |||
| * - it is assumed that string is in UTF-8, the invalid UTF-8 is not processed | |||
| * - all other non-ASCII characters remain as is | |||
| */ | |||
| inline void writeJSONString(const char * begin, const char * end, WriteBuffer & buf) | |||
| inline void writeJSONString(const char * begin, const char * end, WriteBuffer & buf, const FormatSettings & settings = FormatSettings()) | |||
There was a problem hiding this comment.
Try to remove default whenever possible.
There was a problem hiding this comment.
Not in every place the settings are available, e.g. FileChecker::save method doesn't have settings instance available.
How should we approach this case?
There was a problem hiding this comment.
Just create default FormatSettings before call to this function.
If the function is called in the loop - move FormatSettings out of the loop, just in case.
…t_format_json_escape_slashes-setting
… for output_format_json_escape_forward_slashes.
bocharov
deleted the
feature-add-output_format_json_escape_slashes-setting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add output_format_json_escape_slashes setting - controls escaping slashes for string outputs in JSON output format.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en