Add row_delimiter argument to StorageKafka. #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok! Could you please try to add an integration test? |
|
Um, I don't find any existing intergration tests related to kafka and don't know how to setup one. |
|
Could you please try to add a test? |
|
OK, I'll try to add one. |
There are common cases where a message doesn't end with a row delimiter. This patch allows specifying a row_delimiter char to compensate that. ClickHouse#2298
|
@alexey-milovidov I've added a simpe kafka integration test. |
This was referenced Jul 25, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Jul 25, 2018
This was referenced Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are common cases where a message doesn't end with a row delimiter.
This patch allows specifying a row_delimiter char to compensate that.
#2298
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en