Make OPTIMIZE be able to merge all parts with FINAL. #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have implemented it only for MergeTree, not for Replicated variants. |
alexey-milovidov
added a commit
that referenced
this pull request
Jul 5, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Jul 5, 2018
|
Ah, is it straghtforward to apply the merge loop for Replicated variants? |
|
It should work in about the same way. There are some considerations in usability. When you execute an OPTIMIZE query it will create many merges in the replication queue and merges of new parts won't be created for a long period of time. If you have inserts in your table, they will end up refused with the message "Too many parts..." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en