Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank space while resizing #165

Open
ethedev opened this issue Dec 9, 2021 · 2 comments
Open

Fix blank space while resizing #165

ethedev opened this issue Dec 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@ethedev
Copy link
Member

ethedev commented Dec 9, 2021

Eventually there is a point where the dynamic resizing seems to break and is in between mobile and desktop modes with a blank space on the left, none on the right, and the wallet info on the bottom.

  • fix sidebar blank space thats replacing the synths rows, its happening while resizing

image

@ethedev ethedev added this to the New Synths milestone Dec 9, 2021
@ethedev
Copy link
Member Author

ethedev commented Dec 9, 2021

@rossgalloway some clarification on this?

@rossgalloway
Copy link

This comment has to be read in context of issue 164 (#164) and 166 (#166). They are all about the way the page resizes. Fixing one without thinking about the others is not going to lead to good results.

The person fixing this issue needs to open the website and shrink the page width slowly from widescreen to mobile and see where it breaks or changes in how the site is viewed. The wide side has 3 columns: left, center, and right. As the page width shrinks they should act uniformly according to how @blokku-chan has imagined it. At some point the mode will need to flip into a mobile mode for narrow screens, maybe with an in between mode for 4:3 or something. Right now there are places (like the above image) where that changes inconsistently and one of the columns just disappears for a moment.

If the person fixing this has questions then they can ask, but they should be reading the full comments I made because I'm not looking at any of this in a vacuum.

@ethedev ethedev added the enhancement New feature or request label Dec 10, 2021
@ethedev ethedev removed this from the New Synths milestone Dec 10, 2021
@ethedev ethedev moved this to Blocked in Yam Synths Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants