Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metamask bug, if user has just connected to metamask but there are no addresses initialized on the metamask extension, it will break the page #149

Open
ethedev opened this issue Nov 29, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@ethedev
Copy link
Member

ethedev commented Nov 29, 2021

On the case where the request type to metamask is wallet_requestPermissions the website must wait and not break (header and footer disappearing) for when metamask sends back a response, then on connection success the address should just be loaded in.

inpage.js:1 MetaMask - RPC Error: Request of type 'wallet_requestPermissions' already pending for origin https://deploy-preview-158--modest-leavitt-3a2875.netlify.app. Please wait. Object
@ghost
Copy link

ghost commented Dec 4, 2021

Hm.. so it allows you to connect to the dapp even if you have not created an account on metamask and just installed the extension?

@ethedev
Copy link
Member Author

ethedev commented Dec 9, 2021

correct

@ethedev
Copy link
Member Author

ethedev commented Dec 9, 2021

additional errors might show:

vendor.cb1e225a.js:6 TypeError: Cannot read properties of null (reading 'slice')
    at L (AppView.086a48ec.js:6)
    at Proxy.<anonymous> (AppView.086a48ec.js:6)
    at Pd (vendor.cb1e225a.js:6)
    at yd.W [as fn] (vendor.cb1e225a.js:6)
    at yd.run (vendor.cb1e225a.js:6)
    at c5 (vendor.cb1e225a.js:6)
    at G_ (vendor.cb1e225a.js:6)
U$ @ vendor.cb1e225a.js:6
vendor.cb1e225a.js:6 TypeError: Cannot read properties of null (reading 'slice')
    at h (AppView.086a48ec.js:6)
    at Proxy.<anonymous> (AppView.086a48ec.js:6)
    at Pd (vendor.cb1e225a.js:6)
    at yd.W [as fn] (vendor.cb1e225a.js:6)
    at yd.run (vendor.cb1e225a.js:6)
    at c5 (vendor.cb1e225a.js:6)
    at G_ (vendor.cb1e225a.js:6)

@ethedev ethedev added the bug Something isn't working label Dec 9, 2021
@ethedev ethedev moved this to In Progress in Yam Synths Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant