Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Update Firebase Analytics to 17.5.0 #8

Open
RandomShaper opened this issue Aug 17, 2020 · 0 comments · May be fixed by #9
Open

Request: Update Firebase Analytics to 17.5.0 #8

RandomShaper opened this issue Aug 17, 2020 · 0 comments · May be fixed by #9

Comments

@RandomShaper
Copy link

RandomShaper commented Aug 17, 2020

Firebase Analytics had manual screen view tracking quit messed up until recently.

  • Before:
    They have the predefined screen_view, but you would get an error if trying to manually send it. You should use setScreenName(), but it had the issue that, due to automatic activity tracking, two screen_view events would get logged. (setScreenName() was not anyway exposed in this plugin. Just mentioning it to tell the whole story.)

  • Now:
    They deprecated setScreenName() and now you can submit screen_view events manually, which gets us rid of the mentioned issues. For that to work, you need Firebase Analytics 17.5.0.

My request is therefore to upgrade the relevant library, like this:

com.google.firebase:firebase-analytics:17.5.0

I've done it for my game and it's working fine.

By the way, since I'm only using Analytics, that's actually the only entry I've left in Firebase.release.gdap. I've even removed androidx.work:work-runtime:2.3.4 and com.google.guava:guava:29.0-android since they don't seem to be needed, at least for it. Are they really needed for the other Firebase packages?


I take the opportunity to thank you for this Firebase integration. It works fine and saves a lot of time.

@RandomShaper RandomShaper linked a pull request Aug 17, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant