Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure Grid Units break in IE7 #154

Closed
tilomitra opened this issue Jul 31, 2013 · 3 comments · Fixed by #157
Closed

Pure Grid Units break in IE7 #154

tilomitra opened this issue Jul 31, 2013 · 3 comments · Fixed by #157

Comments

@tilomitra
Copy link
Contributor

The grid breaks when you have grid units that span multiple rows. Here's a fiddle that demonstrates the breakage:

http://jsfiddle.net/C4PQQ/2/

On IE7, you see this:
ie7 grids

I believe this has to do with how IE rounds sub-pixel values. I have a fix for this in #147. In the fiddle, uncomment the new .pure-u-* classes to see the fix.

The new *widths were determined by incrementally decreasing from the width until I got it to reliably work with a various permutations of different grid unit widths.

@thierryk ran into a similar issue on his work with YUI Grids. A similar solution is also used by Bootstrap for their fluid grids. However, I found the Bootstrap *width subtracts too much from the width. We ideally want those two values to be as close as possible.

@ericf
Copy link
Collaborator

ericf commented Jul 31, 2013

I cannot reproduce:

@kunl
Copy link

kunl commented Aug 1, 2013

unnamed
同样的问题,pure-u-_-_不能占满全行

@fuwaneko
Copy link

fuwaneko commented Aug 1, 2013

IE7? Really? I mean it's 7 years old browser and it is not supported by Microsoft anymore.

tilomitra added a commit to tilomitra/pure that referenced this issue Aug 1, 2013
tilomitra added a commit to tilomitra/pure that referenced this issue Aug 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants