Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depending on mimemagic, licensing problem with GPL #84

Closed
oakbow opened this issue Mar 25, 2021 · 13 comments
Closed

depending on mimemagic, licensing problem with GPL #84

oakbow opened this issue Mar 25, 2021 · 13 comments

Comments

@oakbow
Copy link
Contributor

oakbow commented Mar 25, 2021

carrierwaveuploader/carrierwave#2548

The gem mimemagic was previously licensed under MIT, but all existing versions were yanked this morning and replaced with new versions licensed under GPL in order to resolve a licensing issue (mimemagicrb/mimemagic#97). The Rails community is currently working to update or replace this dependency, so that Rails apps are not required to be licensed under the GPL by default (rails/rails#41750).

like Carrierwave, carrierwave-base64 has same problems with get_file_extension method.

with this problem, we can not build/deploy/release our rails applications

@anhntq6
Copy link

anhntq6 commented Mar 25, 2021

now, my project can't deploy. @y9v Can you hepl me fix this error

@oakbow
Copy link
Contributor Author

oakbow commented Mar 25, 2021

without thinking about licensing, you can deploy your project after executing bundle update mimemagic.
all old versions are yanked because of the license issue, but mimemagic 0.3.6 is released under GPL.
of course you need to consider it is valid to install GPL gem into your project

@anhntq6

@y-okamoto-1113
Copy link

@y9v
i also have the same problem.
mimemagic 0.3.6 and 0.3.7 were yanked.
Instead, 0.3.8 and 0.3.9 and 0.4.2 were released.
mimemagicrb/mimemagic@f14e3bf

when i install mimemagic (0.4.2), a warning message was displayed.
Can you hepl me fix this warning.

Your lockfile doesn't include a valid resolution.
You can fix this by regenerating your lockfile or trying to manually editing the bad locked gems to a version that satisfies all dependencies.
The unmet dependencies are:
* mimemagic (~> 0.3.2), depended upon carrierwave-base64-2.8.0, unsatisfied by mimemagic-0.4.2

@oakbow
Copy link
Contributor Author

oakbow commented Mar 26, 2021

how about using mimemagic 0.3.9 @y-okamoto-1113

@oakbow
Copy link
Contributor Author

oakbow commented Mar 27, 2021

new version of Rails(Marcel) have been released which is removed mimemagic dependency.
now marcel has compatible methods with mimemagic.
I guess it is the most easy way to replace mimemagic with marcel, like carrierwave carrierwaveuploader/carrierwave#2551

@justisb
Copy link
Contributor

justisb commented Mar 28, 2021

We need CarrierWave to release the new version with the Marcel dependency, but then I think this gem could be updated to also use Marcel fairly easily.

@oakbow
Copy link
Contributor Author

oakbow commented Mar 28, 2021

I made a pull request for removing mimemagic dependency.

@justisb
Copy link
Contributor

justisb commented Mar 28, 2021

Once CarrierWave releases their update, this gem should also bump the minimum required carrierwave dependency version to match the release containing Marcel. Hopefully the CarrierWave gem gets a new release soon.

@y9v
Copy link
Owner

y9v commented Mar 29, 2021

@oakbow @justisb unfortunately we have to wait for carrierwave to release an updated version first.

@oakbow
Copy link
Contributor Author

oakbow commented Mar 30, 2021

carrierwave has been updated to 2.2.1. it has been free from mimemagic @y9v

@justisb
Copy link
Contributor

justisb commented Mar 30, 2021

@oakbow Perhaps you could re-submit your PR that was reverted, but with the carrierwave dependency bumped to >= 2.2.1.

Then after a new release of carrierwave-base64, everyone will just need to update carrierwave, carrierwave-base64, and rails gems to be free of mimemagic.

@oakbow
Copy link
Contributor Author

oakbow commented Mar 30, 2021

@y9v
I made a new PR to be free from mimemagic completely. #87
please review it, thank you.

@y9v
Copy link
Owner

y9v commented Mar 30, 2021

@justisb @oakbow thank you for your contribution, very much appreciated. I released 2.9.0, which does not depend on mimemagic anymore

@y9v y9v closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants