Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect line height with canvas #992

Closed
mofux opened this issue Sep 14, 2017 · 1 comment
Closed

Incorrect line height with canvas #992

mofux opened this issue Sep 14, 2017 · 1 comment

Comments

@mofux
Copy link
Contributor

mofux commented Sep 14, 2017

Look at the screenshot. Notice the cyan border. In xterm.js (top picture), there is a visible gap between the | strokes. With lineHeight set to 1, I would expect the output to look exactly as in Terminal.app (bottom picture). I think this is caused because we Math.ceil the measured character height.

line-height

@Tyriar
Copy link
Member

Tyriar commented Sep 14, 2017

I think this is related to the default font. Both these work great:

term.setOption('fontFamily', 'Fira Code')
term.setOption('fontFamily', 'Hack')

screen shot 2017-09-14 at 9 10 05 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants