-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom xterm keybindings to be turned off by consumers (and provide APIs for them) #264
Comments
I am 👍 on this. I think one good thing we could do is create an API which is compatible with the This could provide great experience with the user's customization's available out-of-the-box, when xterm.js is wrapped in native applications like vscode. |
Yeah I need to check out what's in my |
hmmm...? Xterm reads .inputrc? from my understanding, .inputrc is for Readline, not related to Xterm. |
It was just a proposal to understand the syntax. X resources seems more suitable though. |
I'm closing this off to keep out issue count lower as it hasn't gained any traction, is stale or is not worth tracking. |
@Tyriar Hi, should this problem be fixed? The command
|
I dont quite get the idea behind those "// HACK: Make Alt + left-arrow behave like Ctrl + left-arrow:" changes in Keyboard.ts. By what were these hacks justified? Why would anyone want Alt+Arrow to behave exactly like Ctrl+Arrow? |
@jerch it might have been me making things act as I would have expected when I was a noob. If so these should probably be in vscode's keybindings instead |
@Tyriar Ah no worries, was just trying to get the idea behind that change, and I was not able to find the reason in the old issues/commits. Because if there is a good reason, we prolly cannot simply change it to something else. 👍 To make it somehow configurable is prolly the best idea. Hopefully thats not too tricky, I always get the impression, that the key handling code is full of pitfalls and fixing one thing will break 2 others 😅 |
The custom keybindings request in xterm.js was eventually closed as embedders can set it up to do whatever they want. My philosophy since then has been do baseline behavior in xterm.js and anything non-standard in embedders where you can probably configure as a user. Some built-in examples in vscode that try make the terminal act more like the editor: |
As per #239 (comment) I think things like alt+arrow to jump words should be able to be turned off (or be off by default).
It does make sense for this stuff to be integrated into xterm.js so it works as most people would expect out of the box. However, in vscode for example, I would prefer if alt+arrow for example was routed to vscode's keybinding system so that users can define their own keybindings for this. In other words, I would like to turn this off and have vscode call into a public API to send the "Jump over word left/right" key sequence.
The text was updated successfully, but these errors were encountered: