Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crash handler #1796

Merged
merged 2 commits into from
Jun 29, 2019
Merged

Update crash handler #1796

merged 2 commits into from
Jun 29, 2019

Conversation

mcspr
Copy link
Collaborator

@mcspr mcspr commented Jun 27, 2019

  • limit recorder stack size by 128 bytes (if we crash from sys context, size is ~4Kb. just pre-calculate it even before writing anything). additional 2 bytes used in eeprom to store it
  • offset settings a bit more
  • add possibility to disable storing both crash info and trace. To disable just trace, sysTraceMax can be set to 0. sysSaveCrash check is placed at the start of the crash callback.

Some general updates to comments.
Writer loop now uses the same logic as reader, shifting by address size and writing 32 bit value all at once.

mcspr added 2 commits June 26, 2019 11:23
@mcspr
Update crash handler
dcd8b06 
- limit recorder stack size by 128 bytes
- offset settings a bit more
- add possibility to disable crash crash recoder completely
@mcspr
nicer setting names, comment layout change
283075b
@mcspr mcspr merged commit 08a748e into xoseperez:dev Jun 29, 2019
@mcspr mcspr deleted the sys/crash-settings branch June 29, 2019 22:26
@mcspr mcspr added this to the 1.13.6 milestone Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mcspr