Feature/hama wi fi steckdose

[markusrudolf]

Added a new outlet from HAMA. Do you also need a photo of the device and a howto-flash-it? Then let me know.

https://at.hama.com/00176533/hama-wifi-steckdose-3500w-16a

[mcspr]

Thank you!

One small thing - device define is expected to be combined MANUFACTURER "_" DEVICE, so DEVICE should be WIFI_STECKDOSE_00176533. And... any reason to keep the number code? mb just WIFI_STECKDOSE?

[markusrudolf]

On 02.03.2019 17:16, Max Prokhorov wrote: Thank you! One small thing - device define is expected to be combined MANUFACTURER "_" DEVICE, so DEVICE should be

That would be HAMA_WIFI_STECKDOSE_00176533 then. I can make the changes if needed.

WIFI_STECKDOSE_00176533. And... any reason to keep the number code? mb just WIFI_STECKDOSE? —

The thing is there is an absolutely identical looking one with different number code for German market I guess, but i don't own one and cannot make assumptions if it's identical hardware wise. Maybe someone has one and can confirm it, but for now I think its safer to have the model code included just in case someone sees the picture, thinks "ah looks like mine" , flashes it and then bricks his socket.

…

You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1598 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4qfRsHb1SVKZzrp9xQ26_TtqhfkIa2ks5vSqP2gaJpZM4baaOE>.

[mcspr]

Please do. Let's keep the number.

[markusrudolf]

That should be already in the required format in my latest commit (a861707) You may pull then if there are no other objections.

[markusrudolf]

I can work on documentation. What is the best approach for this? Clone the Wiki GIT repo, add the pages missing for HAMA device (how to flash, pinout for UART etc) and do a pull request?

[mcspr]

About the documentation:
Github does not expose pull requests or any git webui for wiki repo. You can clone and edit the wiki locally, but you'll need a different repo to push to, which I can merge manually (access rights!)
One option is to use Wiki on your fork, see here to enable it: https://github.com/markusrudolf/espurna/settings

[markusrudolf]

@mcspr commented on this pull request. About the documentation: Github does not expose pull requests or any git webui for wiki repo. You can clone and edit the wiki locally, but you'll need a different repo to push to, which I can merge manually (access rights!) One option is to use Wiki on your fork, see here to enable it: https://github.com/markusrudolf/espurna/settings Ok Will look into that

________________________________ In code/espurna/config/hardware.h<#1598 (comment)>:

@@ -3567,6 +3567,24 @@

#define SSDP_SUPPORT 1 #define RF_SUPPORT 1 +#elif defined(HAMA_WIFI_STECKDOSE_00176533) + + // Info + #define MANUFACTURER "HAMA" + #define DEVICE "WiFi-Steckdose 00176533" ⬇️ Suggested change - #define DEVICE "WiFi-Steckdose 00176533" + #define DEVICE "WIFI_STECKDOSE_00176533" I meant this I see sorry got confused. Thought these defines end up in the GUI and would be more readable, but will fix NP

________________________________ In code/platformio.ini<#1598 (comment)>:

@@ -3178,3 +3178,14 @@ upload_port = ${common.upload_port}

upload_flags = ${common.upload_flags} monitor_speed = ${common.monitor_speed} extra_scripts = ${common.extra_scripts} + +[env:hama-wifi-steckdose-00176533] +platform = ${common.platform} +framework = ${common.framework} +board = ${common.board_1m} +board_build.flash_mode = ${common.flash_mode} +lib_deps = ${common.lib_deps} +lib_ignore = ${common.lib_ignore} +build_flags = ${common.build_flags_1m0m} -DHAMA_WIFI_STECKDOSE_00176533 +monitor_speed = ${common.monitor_speed} +extra_scripts = ${common.extra_scripts} ⬇️ Suggested change

…

-extra_scripts = ${common.extra_scripts} +extra_scripts = ${common.extra_scripts} + +[env:hama-wifi-steckdose-00176533-ota] +platform = ${common.platform} +framework = ${common.framework} +board = ${common.board_1m} +board_build.flash_mode = ${common.flash_mode} +lib_deps = ${common.lib_deps} +lib_ignore = ${common.lib_ignore} +build_flags = ${common.build_flags_1m0m} -DHAMA_WIFI_STECKDOSE_00176533 +upload_port = ${common.upload_port} +upload_flags = ${common.upload_flags} +monitor_speed = ${common.monitor_speed} +extra_scripts = ${common.extra_scripts} Duplicated env for -t upload via OTA. Platformio is weird like that. I think this can be reworked as custom target / .ini generator. But for now it is like this — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#1598 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA4qfY5mWKdVJ2oEKsfR5OWkMZopj6RUks5vStr3gaJpZM4baaOE>. Ok will adapt this. Also maybe its better to move the code above the travis pseudo target stuff while I am at it?

[markusrudolf]

Sorry for messing up the formatting in my reply, the mail client kinda messed it up :-/
I merged in the suggestions you made. I didn't test the OTA function but it builds. The binaries are same size though. Is there any change for an OTA image? Like different file header or something?

If you want to pull now feel free

[mcspr]

No problem, merged.

-ota produces the same .bin, it is strictly for platformio. it will pick up upload_flags and upload_port from environment variables.

[markusrudolf]

I prepared a rough draft documentation on my fork of the wiki. See here

Needs to be still put into TOC and such. Comments welcome.

[mcspr]

Yes, I've seen the first draft yesterday :) Nothing stands out to me, merged into the wiki. Thanks!